Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756098AbbEUR6z (ORCPT ); Thu, 21 May 2015 13:58:55 -0400 Received: from cantor2.suse.de ([195.135.220.15]:41756 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755552AbbEUR6s (ORCPT ); Thu, 21 May 2015 13:58:48 -0400 Message-ID: <555E1CC4.9090605@suse.de> Date: Thu, 21 May 2015 19:58:28 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= Organization: SUSE Linux GmbH User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Maxime Coquelin CC: Mark Rutland , "linux-doc@vger.kernel.org" , Linus Walleij , Will Deacon , Stefan Agner , Nikolay Borisov , Peter Meerwald , Lee Jones , Linux-Arch , Daniel Thompson , Russell King , Pawel Moll , Jonathan Corbet , Jiri Slaby , Daniel Lezcano , Chanwoo Choi , Andy Shevchenko , Antti Palosaari , Geert Uytterhoeven , "linux-serial@vger.kernel.org" , =?ISO-8859-15?Q?Uwe_Kleine-K=F6nig?= , "devicetree@vger.kernel.org" , Kees Cook , Arnd Bergmann , Mauro Carvalho Chehab , Kamil Lulko , Rusty Russell , "linux-gpio@vger.kernel.org" , Rob Herring , Kumar Gala , Thomas Gleixner , Ian Campbell , Nicolae Rosia , "linux-arm-kernel@lists.infradead.org" , Michal Marek , Paul Bolle , Peter Hurley , "linux-api@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Philipp Zabel , Greg Kroah-Hartman , Joe Perches , Tejun Heo , Andrew Morton , "David S. Miller" , Vladimir Zapolskiy Subject: Re: [PATCH v8 07/16] drivers: reset: Add STM32 reset driver References: <1431158038-3813-1-git-send-email-mcoquelin.stm32@gmail.com> <1431158038-3813-8-git-send-email-mcoquelin.stm32@gmail.com> <555D1C7D.1060205@suse.de> In-Reply-To: Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1619 Lines: 44 Am 21.05.2015 um 09:46 schrieb Maxime Coquelin: > 2015-05-21 1:45 GMT+02:00 Andreas F?rber : >> Am 09.05.2015 um 09:53 schrieb Maxime Coquelin: >>> +static const struct of_device_id stm32_reset_dt_ids[] = { >>> + { .compatible = "st,stm32-rcc", }, >>> + { /* sentinel */ }, >>> +}; >>> +MODULE_DEVICE_TABLE(of, sstm32_reset_dt_ids); >> >> Typo. > > Indeed, thanks for pointing this out. > >> >> IIUC the timer depends on the reset controller, so it must be built in >> anyway, and that's what's enforced in the Makefile above. Drop the line? >> > > Agree it must be built-in. > I will fix that in next version. Actually, I've updated a timer implementation of mine to invoke a reset controller similar to how you do in the STM32 clocksource patch, but no reset controller is getting returned. It seems to me, you are working around that by simply ignoring the error in the timer code and not doing a reset then, so the STM32 timer does in fact _not_ depend on the reset controller? What happened to your efforts of making the reset controller usable for the timer? In my case, my timer is originally in reset state and needs to be deasserted, so I can't just ignore it. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Felix Imend?rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N?rnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/