Message-ID: <555E2656.5030503@kernel.dk>
Date: Thu, 21 May 2015 12:39:18 -0600
From: Jens Axboe <axboe@kernel.dk>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Parav Pandit <parav.pandit@avagotech.com>, linux-nvme@lists.infradead.org,
        willy@linux.intel.com
CC: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] NVMe: Avoid interrupt disable during queue init.
References: <1432253553-17045-1-git-send-email-parav.pandit@avagotech.com>
In-Reply-To: <1432253553-17045-1-git-send-email-parav.pandit@avagotech.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 723
Lines: 20

On 05/21/2015 06:12 PM, Parav Pandit wrote:
> Avoid diabling interrupt and holding q_lock for the queue
> which is just getting initialized.
>
> With this change, online_queues is also incremented without
> lock during queue setup stage.
> if Power management nvme_suspend() kicks in during queue setup time,
> per nvmeq based q_lock spinlock cannot protect device wide
> online_queues variable anyway.

Seems fairly pointless, it's not like it's a hot path...

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/