Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755596AbbEUTOz (ORCPT ); Thu, 21 May 2015 15:14:55 -0400 Received: from mail-ie0-f177.google.com ([209.85.223.177]:35850 "EHLO mail-ie0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751491AbbEUTOy (ORCPT ); Thu, 21 May 2015 15:14:54 -0400 MIME-Version: 1.0 In-Reply-To: <555E2656.5030503@kernel.dk> References: <1432253553-17045-1-git-send-email-parav.pandit@avagotech.com> <555E2656.5030503@kernel.dk> Date: Fri, 22 May 2015 00:44:53 +0530 Message-ID: Subject: Re: [PATCH] NVMe: Avoid interrupt disable during queue init. From: Parav Pandit To: Jens Axboe Cc: linux-nvme@lists.infradead.org, Matthew Wilcox , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1022 Lines: 29 On Fri, May 22, 2015 at 12:09 AM, Jens Axboe wrote: > On 05/21/2015 06:12 PM, Parav Pandit wrote: >> >> Avoid diabling interrupt and holding q_lock for the queue >> which is just getting initialized. >> >> With this change, online_queues is also incremented without >> lock during queue setup stage. >> if Power management nvme_suspend() kicks in during queue setup time, >> per nvmeq based q_lock spinlock cannot protect device wide >> online_queues variable anyway. > > > Seems fairly pointless, it's not like it's a hot path... > I didn't follow your comments. Do you mean we should still hold the lock, even if its not needed? I meant to say in above patch/comment that holding q_lock is not necessary in this path. So I removed it. > -- > Jens Axboe > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/