Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932317AbbEUT4q (ORCPT ); Thu, 21 May 2015 15:56:46 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:52924 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422780AbbEUT4k (ORCPT ); Thu, 21 May 2015 15:56:40 -0400 Date: Thu, 21 May 2015 21:56:15 +0200 From: Darren Hart To: Jim Davis Cc: Stephen Rothwell , linux-next , linux-kernel , pali.rohar@gmail.com, platform-driver-x86@vger.kernel.org Subject: Re: randconfig build error with next-20150521, in drivers/platform/x86/dell-rbtn.c Message-ID: <20150521195615.GF22037@vmdeb7> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1484 Lines: 39 On Thu, May 21, 2015 at 10:36:15AM -0700, Jim Davis wrote: > Building with the attached random configuration file, > > drivers/built-in.o: In function `rbtn_remove': > dell-rbtn.c:(.text+0x31d7f4): undefined reference to `input_unregister_device' > drivers/built-in.o: In function `rbtn_notify': > dell-rbtn.c:(.text+0x31d8e5): undefined reference to `input_event' > dell-rbtn.c:(.text+0x31d8f8): undefined reference to `input_event' > dell-rbtn.c:(.text+0x31d911): undefined reference to `input_event' > dell-rbtn.c:(.text+0x31d924): undefined reference to `input_event' > drivers/built-in.o: In function `rbtn_add': > dell-rbtn.c:(.text+0x31da11): undefined reference to `input_allocate_device' > dell-rbtn.c:(.text+0x31da4a): undefined reference to `input_register_device' > dell-rbtn.c:(.text+0x31da5e): undefined reference to `input_free_device' > Makefile:938: recipe for target 'vmlinux' failed Thanks Jim, Pali, the DELL_RBTN needs to ensure if it it's built-in, that INPUT is too. ... > CONFIG_INPUT=m > CONFIG_INPUT_FF_MEMLESS=m > CONFIG_INPUT_POLLDEV=m > CONFIG_INPUT_SPARSEKMAP=m > CONFIG_INPUT_MATRIXKMAP=m ... > CONFIG_DELL_RBTN=y Please submit a fix as a new patch. -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/