Message-ID: <1432242004.20840.68.camel@perches.com>
Subject: Re: [PATCH v4 10/13] staging: lustre: lnet: lnet: checkpatch.pl
 fixes
From: Joe Perches <joe@perches.com>
To: Mike Shuey <shuey@purdue.edu>
Cc: oleg.drokin@intel.com, devel@driverdev.osuosl.org,
        gregkh@linuxfoundation.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org, HPDD-discuss@ml01.01.org,
        lustre-deve@lists.lustre.org
Date: Thu, 21 May 2015 14:00:04 -0700
In-Reply-To: <1432237849-53947-11-git-send-email-shuey@purdue.edu>
References: <1432237849-53947-1-git-send-email-shuey@purdue.edu>
	 <1432237849-53947-11-git-send-email-shuey@purdue.edu>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1110
Lines: 29

On Thu, 2015-05-21 at 15:50 -0400, Mike Shuey wrote:
> Fix many checkpatch.pl warnings.
[]
> diff --git a/drivers/staging/lustre/lnet/lnet/acceptor.c b/drivers/staging/lustre/lnet/lnet/acceptor.c
[]
> @@ -99,38 +99,42 @@ lnet_connect_console_error(int rc, lnet_nid_t peer_nid,
>  	switch (rc) {
>  	/* "normal" errors */
>  	case -ECONNREFUSED:
> -		CNETERR("Connection to %s at host %pI4h on port %d was refused: check that Lustre is running on that node.\n",
> -			libcfs_nid2str(peer_nid),
> -			&peer_ip, peer_port);
> +		CNETERR(
> +			"Connection to %s at host %pI4h on port %d was refused: check that Lustre is running on that node.\n",
> +			libcfs_nid2str(peer_nid), &peer_ip, peer_port);

These are not improvements and checkpatch messages aren't dicta.

Please don't convert code unless the conversion makes it better
for a human reader.

These don't.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/