Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756583AbbEUV73 (ORCPT ); Thu, 21 May 2015 17:59:29 -0400 Received: from mail-gw3-out.broadcom.com ([216.31.210.64]:14202 "EHLO mail-gw3-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754247AbbEUV72 (ORCPT ); Thu, 21 May 2015 17:59:28 -0400 X-IronPort-AV: E=Sophos;i="5.13,472,1427785200"; d="scan'208";a="65374609" Message-ID: <555E553A.3030705@broadcom.com> Date: Thu, 21 May 2015 14:59:22 -0700 From: Ray Jui User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Kishon Vijay Abraham I CC: , "JD (Jiandong) Zheng" , Arun Parameswaran , Subject: Re: [PATCH 3/5] phy: cygnus: pcie: Define DT binding References: <1432085014-20758-1-git-send-email-rjui@broadcom.com> <1432085014-20758-4-git-send-email-rjui@broadcom.com> <555DDA4D.5070906@ti.com> In-Reply-To: <555DDA4D.5070906@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1964 Lines: 64 On 5/21/2015 6:14 AM, Kishon Vijay Abraham I wrote: > Hi, > > On Wednesday 20 May 2015 06:53 AM, Ray Jui wrote: >> Add DT binding document for Broadcom Cygnus PCIe PHY driver >> >> Signed-off-by: Ray Jui >> Reviewed-by: Arun Parameswaran >> Reviewed-by: JD (Jiandong) Zheng >> Reviewed-by: Scott Branden >> --- >> .../bindings/phy/brcm,cygnus-pcie-phy.txt | 31 >> ++++++++++++++++++++ >> 1 file changed, 31 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt >> >> diff --git >> a/Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt >> b/Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt >> new file mode 100644 >> index 0000000..36745ee >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/brcm,cygnus-pcie-phy.txt > > brcm-cygnus-pcie-phy.txt? >> @@ -0,0 +1,31 @@ >> +Broadcom Cygnus PCIe PHY >> + >> +Required properties: >> +- compatible: Must be "brcm,cygnus-pcie-phy" >> +- reg: base address and length of the CRMU block >> +- #phy-cells: must be <2> >> +The first cell is the PHY ID: >> +0 - PCIe RC 0 >> +1 - PCIe RC 1 >> +The second cell is the internal PHY address >> + >> +Example: >> + phy: phy@0301d0a0 { >> + compatible = "brcm,cygnus-pcie-phy"; >> + reg = <0x0301d0a0 0x14>; >> + #phy-cells = <2>; >> + }; > > IMHO these nodes should be child nodes of the mdio node. Are they > modelled that way? > > Thanks > Kishon Currently they are not. But you are right. It makes more sense for the PHY nodes to be declared under the MDIO bus node. I will make that change. Thanks, Ray -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/