Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964822AbbEUWVJ (ORCPT ); Thu, 21 May 2015 18:21:09 -0400 Received: from mail-qk0-f177.google.com ([209.85.220.177]:33233 "EHLO mail-qk0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750875AbbEUWVG (ORCPT ); Thu, 21 May 2015 18:21:06 -0400 Date: Thu, 21 May 2015 18:20:59 -0400 From: Tejun Heo To: Fabio Estevam Cc: Brian Norris , Kishon Vijay Abraham I , Mark Rutland , "devicetree@vger.kernel.org" , Hans de Goede , Florian Fainelli , Pawel Moll , Ian Campbell , Kevin Cernekee , linux-kernel , linux-ide@vger.kernel.org, Rob Herring , bcm-kernel-feedback-list@broadcom.com, Gregory Fong , Kumar Gala , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3 3/5] ata: add Broadcom AHCI SATA3 driver for STB chips Message-ID: <20150521222059.GM4914@htj.duckdns.org> References: <1431473303-18873-1-git-send-email-computersforpeace@gmail.com> <1431473303-18873-4-git-send-email-computersforpeace@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 714 Lines: 22 On Thu, May 21, 2015 at 07:16:07PM -0300, Fabio Estevam wrote: > On Tue, May 12, 2015 at 8:28 PM, Brian Norris > wrote: > > > + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ahci"); > > + ahci = devm_ioremap_resource(&pdev->dev, res); > > + if (IS_ERR(ahci)) > > + return 0; > > You should propagate 'return PTR_ERR(ahci)' instead. Brian, can you please update the patch? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/