Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161049AbbEUWVg (ORCPT ); Thu, 21 May 2015 18:21:36 -0400 Received: from mail.skyhub.de ([78.46.96.112]:59637 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932260AbbEUWVd (ORCPT ); Thu, 21 May 2015 18:21:33 -0400 Date: Fri, 22 May 2015 00:21:29 +0200 From: Borislav Petkov To: "Luis R. Rodriguez" Cc: gregkh@linuxfoundation.org, davem@davemloft.net, clemens@ladisch.de, dmitry.torokhov@gmail.com, JBottomley@odin.com, airlied@linux.ie, mchehab@osg.samsung.com, herbert@gondor.apana.org.au, marcel@holtmann.org, gustavo@padovan.org, johan.hedberg@gmail.com, starvik@axis.com, jesper.nilsson@axis.com, kaloz@openwrt.org, khalasa@piap.pl, ohad@wizery.com, arnd@arndb.de, 3chas3@gmail.com, jslaby@suse.cz, cooloney@gmail.com, rpurdie@rpsys.net, j.anaszewski@samsung.com, pebolle@tiscali.nl, tiwai@suse.de, linux-kernel@vger.kernel.org Subject: Re: [RFC v1] tree-wide: remove "select FW_LOADER" uses Message-ID: <20150521222129.GI3689@pd.tnic> References: <1432241149-8762-1-git-send-email-mcgrof@do-not-panic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1432241149-8762-1-git-send-email-mcgrof@do-not-panic.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1311 Lines: 36 On Thu, May 21, 2015 at 01:45:49PM -0700, Luis R. Rodriguez wrote: > The above history is just *one* set of reasons to remove all kernel > "select FW_LOADER" entries. Another simple reason is that since > FW_LOADER can only be disabled by an EXPERT and it defaults to y > its now a superfluous select. We will ensure things build for you > if using EXPERT but if you have selected EXPERT you should know > what run time requirements you need. Couple of notes only: So the "depends" thing is a step backwards IMO because people would have to go and enable FW_LOADER first. For the microcode loader, at least, "select" is perfectly fine. There's also the other aspect that this FW_LOADER thing ends up enabled on 99.9% (!?) of the distro installations anyway, right? I.e., there's always something needing firmware from userspace. So the current "default y" behind EXPERT is probably the correct thing anyway. So yeah, send me the x86 microcode loader patch, I'll take it. Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/