Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756129AbbEUWYp (ORCPT ); Thu, 21 May 2015 18:24:45 -0400 Received: from mail-qk0-f170.google.com ([209.85.220.170]:33083 "EHLO mail-qk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750964AbbEUWYm (ORCPT ); Thu, 21 May 2015 18:24:42 -0400 MIME-Version: 1.0 In-Reply-To: <1432244260-14908-4-git-send-email-ezequiel.garcia@imgtec.com> References: <1432244260-14908-1-git-send-email-ezequiel.garcia@imgtec.com> <1432244260-14908-4-git-send-email-ezequiel.garcia@imgtec.com> Date: Thu, 21 May 2015 15:24:41 -0700 X-Google-Sender-Auth: sJ5FYrkBLo1nwJ24WlvIzxbkuDE Message-ID: Subject: Re: [PATCH 3/7] clocksource: mips-gic: Split clocksource and clockevent initialization From: Andrew Bresticker To: Ezequiel Garcia Cc: "linux-kernel@vger.kernel.org" , Linux-MIPS , Daniel Lezcano , "devicetree@vger.kernel.org" , James Hartley , James Hogan , Thomas Gleixner , Damien Horsley , Govindraj Raja Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1521 Lines: 36 On Thu, May 21, 2015 at 2:37 PM, Ezequiel Garcia wrote: > This is preparation work for the introduction of clockevent frequency > update with a clock notifier. This is only possible when the device > is passed a clk struct, so let's split the legacy and devicetree > initialization. > > Signed-off-by: Ezequiel Garcia > --- > drivers/clocksource/mips-gic-timer.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/drivers/clocksource/mips-gic-timer.c b/drivers/clocksource/mips-gic-timer.c > index c4352f0..22a4daf 100644 > --- a/drivers/clocksource/mips-gic-timer.c > +++ b/drivers/clocksource/mips-gic-timer.c > @@ -142,11 +142,6 @@ static void __init __gic_clocksource_init(void) > ret = clocksource_register_hz(&gic_clocksource, gic_frequency); > if (ret < 0) > pr_warn("GIC: Unable to register clocksource\n"); > - > - gic_clockevent_init(); > - > - /* And finally start the counter */ > - gic_start_count(); > } Instead of duplicating this bit in both the OF and non-OF paths, maybe it would be better to do the notifier registration in gic_clockevent_init(), either by passing around the struct clk or making it a global? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/