Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964798AbbEUXxe (ORCPT ); Thu, 21 May 2015 19:53:34 -0400 Received: from mail-gw1-out.broadcom.com ([216.31.210.62]:45765 "EHLO mail-gw1-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754873AbbEUXxe (ORCPT ); Thu, 21 May 2015 19:53:34 -0400 X-IronPort-AV: E=Sophos;i="5.13,472,1427785200"; d="scan'208";a="65682896" Message-ID: <555E6FFC.2080309@broadcom.com> Date: Thu, 21 May 2015 16:53:32 -0700 From: Ray Jui User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Paul Bolle CC: Kishon Vijay Abraham I , , "JD (Jiandong) Zheng" , Arun Parameswaran , Subject: Re: [PATCH 4/5] phy: cygnus: pcie: Add Cygnus PCIe PHY support References: <1432085014-20758-1-git-send-email-rjui@broadcom.com> <1432085014-20758-5-git-send-email-rjui@broadcom.com> <1432194775.21715.118.camel@x220> In-Reply-To: <1432194775.21715.118.camel@x220> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1863 Lines: 68 On 5/21/2015 12:52 AM, Paul Bolle wrote: > On Tue, 2015-05-19 at 18:23 -0700, Ray Jui wrote: >> --- a/drivers/phy/Kconfig >> +++ b/drivers/phy/Kconfig > >> +config PHY_CYGNUS_PCIE >> + bool "Broadcom Cygnus PCIe PHY driver" >> + depends on ARCH_BCM_CYGNUS >> + select GENERIC_PHY >> + select PHY_IPROC_MDIO >> + default ARCH_BCM_CYGNUS >> + help >> + Enable this to support the Broadcom Cygnus PCIe PHY. >> + >> + The host communicates with the PHY through the iProc MDC/MDIO >> + interface. >> + >> + If unsure, say N. >> + >> + > >> --- a/drivers/phy/Makefile >> +++ b/drivers/phy/Makefile > >> +obj-$(CONFIG_PHY_CYGNUS_PCIE) += phy-cygnus-pcie.o > >> --- /dev/null >> +++ b/drivers/phy/phy-cygnus-pcie.c > >> +#include > >> +static const struct of_device_id cygnus_pcie_phy_match_table[] = { >> + { .compatible = "brcm,cygnus-pcie-phy" }, >> + { } >> +}; >> +MODULE_DEVICE_TABLE(of, cygnus_pcie_phy_match_table); >> + >> +static struct platform_driver cygnus_pcie_phy_driver = { >> + .driver = { >> + .name = "cygnus-pcie-phy", >> + .of_match_table = cygnus_pcie_phy_match_table, >> + }, >> + .probe = cygnus_pcie_phy_probe, >> +}; >> +module_platform_driver(cygnus_pcie_phy_driver); >> + >> +MODULE_AUTHOR("Ray Jui "); >> +MODULE_DESCRIPTION("Broadcom Cygnus PCIe PHY driver"); >> +MODULE_LICENSE("GPL v2"); > > And here I guess you intend this to be buildable as a module. If that's > the intention I think PHY_CYGNUS_PCIE needs to be tristate. Yes, I'll change the PCIe PHY driver to tristate in the Kconfig. Thanks! > > Thanks, > > > Paul Bolle > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/