Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755812AbbEVAQ7 (ORCPT ); Thu, 21 May 2015 20:16:59 -0400 Received: from mga14.intel.com ([192.55.52.115]:32334 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755177AbbEVAQ4 (ORCPT ); Thu, 21 May 2015 20:16:56 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,472,1427785200"; d="scan'208";a="496804205" From: "Zheng, Lv" To: Hanjun Guo , "Wysocki, Rafael J" , "Brown, Len" CC: Lv Zheng , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "Moore, Robert" Subject: RE: [PATCH 12/19] ACPICA: ACPI 6.0: Add changes for MADT table. Thread-Topic: [PATCH 12/19] ACPICA: ACPI 6.0: Add changes for MADT table. Thread-Index: AQHQk9OcIxnbAEmYS0KM1idE3lLUgZ2HIPzQ Date: Fri, 22 May 2015 00:16:51 +0000 Message-ID: <1AE640813FDE7649BE1B193DEA596E8802720DDD@SHSMSX101.ccr.corp.intel.com> References: <555DED69.7040203@linaro.org> In-Reply-To: <555DED69.7040203@linaro.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t4M0H5M9023326 Content-Length: 2099 Lines: 66 Hi, > From: Hanjun Guo [mailto:hanjun.guo@linaro.org] > Sent: Thursday, May 21, 2015 10:36 PM > > Hi Lv, > > On 2015年05月21日 10:31, Lv Zheng wrote: > > From: Bob Moore > > > > ACPICA commit 02cbb41232bccf7a91967140cab95d5f48291f21 > > > > New subtable type. Some additions to existing subtables. > > > > Link: https://github.com/acpica/acpica/commit/02cbb412 > > Signed-off-by: Bob Moore > > Signed-off-by: Lv Zheng > > --- > [...] > > > > /* Masks for Flags field above */ > > @@ -819,7 +822,7 @@ struct acpi_madt_generic_interrupt { > > #define ACPI_MADT_PERFORMANCE_IRQ_MODE (1<<1) /* 01: Performance Interrupt Mode */ > > #define ACPI_MADT_VGIC_IRQ_MODE (1<<2) /* 02: VGIC Maintenance Interrupt mode */ > > > > -/* 12: Generic Distributor (ACPI 5.0) */ > > +/* 12: Generic Distributor (ACPI 5.0 + ACPI 6.0 changes) */ > > > > struct acpi_madt_generic_distributor { > > struct acpi_subtable_header header; > > @@ -827,7 +830,8 @@ struct acpi_madt_generic_distributor { > > u32 gic_id; > > u64 base_address; > > u32 global_irq_base; > > - u32 reserved2; /* reserved - must be zero */ > > + u8 version; > > version filed in generic distributor has following values, > > /* Values for gic_version in Generic Distributor (ACPI 6.0) */ > > enum acpi_madt_gic_ver_type > { > ACPI_MADT_GIC_VER_UNKNOWN = 0, > ACPI_MADT_GIC_VER_V1 = 1, > ACPI_MADT_GIC_VER_V2 = 2, > ACPI_MADT_GIC_VER_V3 = 3, > ACPI_MADT_GIC_VER_V4 = 4, > ACPI_MADT_GIC_VER_RESERVED = 5 /* 5 and greater are > reserved */ > }; > > should we put it here, or locate it to ARM64 arch related head > file? Yes, you can put it here. And also please help to submit an ACPICA patch to . Thanks and best regards -Lv > > Thanks > Hanjun ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?