Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756136AbbEVAzG (ORCPT ); Thu, 21 May 2015 20:55:06 -0400 Received: from TYO202.gate.nec.co.jp ([210.143.35.52]:37508 "EHLO tyo202.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753988AbbEVAzD convert rfc822-to-8bit (ORCPT ); Thu, 21 May 2015 20:55:03 -0400 X-Greylist: delayed 42216 seconds by postgrey-1.27 at vger.kernel.org; Thu, 21 May 2015 20:55:03 EDT From: Hiroshi Shimamoto To: David Miller CC: "jeffrey.t.kirsher@intel.com" , "intel-wired-lan@lists.osuosl.org" , "sy.jong.choi@intel.com" , "ben@decadent.org.uk" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Subject: RE: [PATCH v5] ixgbe: Add module parameter to disable VLAN filter Thread-Topic: [PATCH v5] ixgbe: Add module parameter to disable VLAN filter Thread-Index: AdCTx1mHJagVmEpMTxOl8Bkm/wONlf//mtKA//7YV5A= Date: Fri, 22 May 2015 00:54:31 +0000 Message-ID: <7F861DC0615E0C47A872E6F3C5FCDDBD05EB4CA5@BPXM14GP.gisp.nec.co.jp> References: <7F861DC0615E0C47A872E6F3C5FCDDBD05EB460C@BPXM14GP.gisp.nec.co.jp> <20150521.120713.1811144256149554543.davem@davemloft.net> In-Reply-To: <20150521.120713.1811144256149554543.davem@davemloft.net> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.205.5.123] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1696 Lines: 42 > Subject: Re: [PATCH v5] ixgbe: Add module parameter to disable VLAN filter > > From: Hiroshi Shimamoto > Date: Thu, 21 May 2015 13:10:49 +0000 > > > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > > index 263cb40..b45570f 100644 > > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > > @@ -158,6 +158,10 @@ module_param(allow_unsupported_sfp, uint, 0); > > MODULE_PARM_DESC(allow_unsupported_sfp, > > "Allow unsupported and untested SFP+ modules on 82599-based adapters"); > > > > +static unsigned int disable_hw_vlan_filter; > > +module_param(disable_hw_vlan_filter, uint, 0); > > +MODULE_PARM_DESC(disable_hw_vlan_filter, "Disable HW VLAN filter"); > > Sorry, module parameters like this are not allowed. > > You must use a generic, portable interface, to configure networking > device settings. Could you please tell me which interface is good for this? > > Otherwise every other driver that wants to do something similar will > have yet another module option with a different name, and every user > will suffer because they will need to learn a different mechanism > to perform this configuration for every driver. Right, I agree. But I thought that this requirement seems really special and closed in ixgbe driver, that the reason I tried it with module parameter. thanks, Hiroshi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/