Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755652AbbEVClw (ORCPT ); Thu, 21 May 2015 22:41:52 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:39285 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1754061AbbEVCls (ORCPT ); Thu, 21 May 2015 22:41:48 -0400 X-Listener-Flag: 11101 Message-ID: <1432262503.14396.14.camel@mtksdaap41> Subject: Re: [PATCH 5/5] ARM64: MediaTek MT8173: Add SCPSYS device node From: James Liao To: Sascha Hauer , Daniel Kurtz CC: , Kevin Hilman , "linux-kernel@vger.kernel.org" , , Sasha Hauer , Matthias Brugger , "linux-arm-kernel@lists.infradead.org" Date: Fri, 22 May 2015 10:41:43 +0800 In-Reply-To: <20150521174916.GQ6325@pengutronix.de> References: <1432131540-2523-1-git-send-email-s.hauer@pengutronix.de> <1432131540-2523-6-git-send-email-s.hauer@pengutronix.de> <20150521174916.GQ6325@pengutronix.de> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1579 Lines: 42 Hi Daniel, On Thu, 2015-05-21 at 19:49 +0200, Sascha Hauer wrote: > On Thu, May 21, 2015 at 10:32:40PM +0800, Daniel Kurtz wrote: > > > + scpsys: scpsys@10006000 { > > > + compatible = "mediatek,mt8173-scpsys"; > > > + #power-domain-cells = <1>; > > > + reg = <0 0x10006000 0 0x1000>; > > > + clocks = <&clk26m>, > > > > Why is mfg using <&clk26m> and not <&topckgen CLK_TOP_MFG_SEL>? > > Because James Liao said to me that it is derived from clk26m and not > from mfg_sel. Sascha is right. I had confirmed with our designer that MFG on MT8173 uses clk26m to check state. I also tested MFG domain power on/off with CLK_TOP_MFG_SEL off and it worked correctly. > > I saw another patch set on the list today from James Liao that adds more clocks. > > Perhaps we can move the SCPSYS set on top of that one and include more clocks? > > > > > + <&topckgen CLK_TOP_MM_SEL>; The clocks used by scpsys driver are subsystem bus clocks that need to be on before power on these domains. On MT8173, subsystem bus clocks are come from topckgen. My patch set yesterday add subsystem clocks, which are not needed by power domain on/off. So I think these 2 patch set are independent. Best regards, James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/