Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755862AbbEVDHb (ORCPT ); Thu, 21 May 2015 23:07:31 -0400 Received: from mga01.intel.com ([192.55.52.88]:14522 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754061AbbEVDHa (ORCPT ); Thu, 21 May 2015 23:07:30 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,473,1427785200"; d="scan'208";a="698682005" Date: Thu, 21 May 2015 20:09:54 -0700 From: David Cohen To: Lu Baolu Cc: Heikki Krogerus , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, qiuxu.zhuo@intel.com Subject: Re: [PATCH v2 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall Message-ID: <20150522030954.GA28433@psi-dev26.jf.intel.com> References: <1432260425-2350-1-git-send-email-baolu.lu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432260425-2350-1-git-send-email-baolu.lu@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 861 Lines: 21 Hi, On Fri, May 22, 2015 at 10:07:05AM +0800, Lu Baolu wrote: > Many drivers and modules depend on ULPI bus registeration to > register ULPI interfaces and drivers. It's more appropriate > to register ULPI bus in subsys_initcall instead of module_init. > > Kernel panic has been reported with some kind of kernel config. Even though I agree subsys_initcall is better to register ulpi bus, it's still no excuse to have kernel panic. What about ULPI bus being compiled as module? IMHO this is avoiding the proper kernel panic fix which should be failing gracefully (or defer probe) from tusb1210 driver. Br, David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/