Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756288AbbEVDMM (ORCPT ); Thu, 21 May 2015 23:12:12 -0400 Received: from helcar.hengli.com.au ([209.40.204.226]:42895 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750727AbbEVDMK (ORCPT ); Thu, 21 May 2015 23:12:10 -0400 Date: Fri, 22 May 2015 11:12:00 +0800 From: Herbert Xu To: Linus =?iso-8859-1?Q?L=FCssing?= Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Stephen Hemminger , "David S. Miller" Subject: Re: [PATCH net-next] bridge: allow setting hash_max + multicast_router if interface is down Message-ID: <20150522031200.GA30043@gondor.apana.org.au> References: <1432256161-4425-1-git-send-email-linus.luessing@c0d3.blue> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1432256161-4425-1-git-send-email-linus.luessing@c0d3.blue> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1305 Lines: 28 On Fri, May 22, 2015 at 02:56:01AM +0200, Linus L?ssing wrote: > Network managers like netifd (used in OpenWRT for instance) try to > configure interface options after creation but before setting the > interface up. > > Unfortunately the sysfs / bridge currently only allows to configure the > hash_max and multicast_router options when the bridge interface is up. > But since br_multicast_init() doesn't start any timers and only sets > default values and initializes timers it should be save to reconfigure > the default values after that, before things actually get active after > the bridge is set up. > > With this patch hash_max and multicast_router attributes can be > changed even if the according bridge (port) is down, just like other > other bridge (port) attributes allow too. > > Signed-off-by: Linus L?ssing Acked-by: Herbert Xu -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/