Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756179AbbEVDTU (ORCPT ); Thu, 21 May 2015 23:19:20 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:26753 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753854AbbEVDTR (ORCPT ); Thu, 21 May 2015 23:19:17 -0400 X-AuditID: cbfee691-f79ca6d00000456a-1b-555ea034e08c Date: Fri, 22 May 2015 03:19:02 +0000 (GMT) From: Maninder Singh Subject: Re: [EDT][PATCH 1/1] dma/pl330.c : Initialize pl330 pointer after NULL check of pch pointer To: Vinod Koul Cc: "dan.j.williams@intel.com" , "dmaengine@vger.kernel.org" , "linux-kernel@vger.kernel.org" Reply-to: maninder1.s@samsung.com MIME-version: 1.0 X-MTR: 20150522030619715@maninder1.s Msgkey: 20150522030619715@maninder1.s X-EPLocale: en_US.windows-1252 X-Priority: 3 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-MLAttribute: X-RootMTR: 20150522030619715@maninder1.s X-ParentMTR: X-ArchiveUser: X-CPGSPASS: N X-ConfirmMail: N,general Content-type: text/plain; charset=windows-1252 MIME-version: 1.0 Message-id: <1507989167.25151432264740747.JavaMail.weblogic@epmlwas06d> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrKIsWRmVeSWpSXmKPExsWyRsSkWtdkQVyowczfshaXd81hc2D0+LxJ LoAxissmJTUnsyy1SN8ugStjwa51jAU9khXvHj5kbWDcItHFyMkhJKAmsWjvYzYQW0LARKL1 03MmCFtM4sK99WwQNUsZJT62OMPU7L79EKiGCyg+h1Fi15d9YA0sAqoSE/t+g9lsAvoSZ/eu YwaxhQVSJJbPeskIYosIqEvM+vSJFaSZWWAro8TdK10sEBsUJdbfeAJWxCsgKHFy5hMWiG0q El/XvGOBiKtK3OvZyQwRl5NYMvUy1KW8EjPan7LAxKd9XQNVIy1xftYGRphvFn9/DBXnlzh2 ewdUr4DE1DMHoWo0JXq3/4Wy+STWLHzLAlO/69RyZphd97fMheqVkNja8oQVxGYGun9K90N2 CNtA4siiOazofuEVcJfYN/U81PxeDol3LTETGJVmISmbhWTULCSjkNUsYGRZxSiaWpBcUJyU XmSqV5yYW1yal66XnJ+7iRGYGk7/ezZxB+P9A9aHGAU4GJV4eDnUY0OFWBPLiitzDzGaAuNp IrOUaHI+MAHllcQbGpsZWZiamBobmVuaKYnz6kj/DBYSSE8sSc1OTS1ILYovKs1JLT7EyMTB KdXAeK687LK7xMS9f0598Lm5KdkkeN792ym12bvWu/F4XUjZeojn/y8Hzxqnl/Z1JiV2/3mn ykQ93sYZsnRP8KXOmQwKh57Kzdmr+mnTtNBS/ykTPm6/y/y2dALPpq2XtvzYZFRz28PpXmh0 wQu1kgl6s7Zyzu90nBeuJFqW4F056fiNBx6h8WwzZiuxFGckGmoxFxUnAgC83tPFCAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrBKsWRmVeSWpSXmKPExsVy+t/tPl21BXGhBn13RC0u75rD5sDo8XmT XABjVJpNRmpiSmqRQmpecn5KZl66rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtBQ JYWyxJxSoFBAYnGxkr6dTVF+aUmqQkZ+cYmtUrShuZGekYGeqZGeoWmslaGBgZEpUE1CWsaC XesYC3okK949fMjawLhFoouRk0NIQE1i0d7HbCC2hICJxO7bD5kgbDGJC/fWA8W5gGrmMErs +rIPLMEioCoxse83mM0moC9xdu86ZhBbWCBFYvmsl4wgtoiAusSsT59YQZqZBbYySty90sUC sU1RYv2NJ2BFvAKCEidnPmGB2KYi8XXNOxaIuKrEvZ6dzBBxOYklUy9DXcQrMaP9KQtMfNrX NVA10hLnZ21ghLl68ffHUHF+iWO3d0D1CkhMPXMQqkZTonf7XyibT2LNwrcsMPW7Ti1nhtl1 f8tcqF4Jia0tT1hBbGag+6d0P2SHsA0kjiyaw4ruF14Bd4l9U88zTmCUnYUkNQtJ+ywk7chq FjCyrGIUTS1ILihOSq8w0itOzC0uzUvXS87P3cQITkXPFu1g/Hfe+hCjAAejEg8vh3psqBBr YllxZe4hRgkOZiURXr36uFAh3pTEyqrUovz4otKc1OJDjKbAaJvILCWanA9Mk3kl8YbGJuam xqYWBobm5mZK4rz/z+WGCAmkJ5akZqemFqQWwfQxcXBKNTAqdblcMbO79WPH5Oi1+Z62Cqfn BHrEzvt2jb2O413m7dSvGt4avcs9lyTvE7x5aYWT7MKJv1ZXHrj/TXWd1uW1ExnUBET+KP5O e2u82Zbj2aE4R0adnrZ4HvPYrTYsvkYrmPi3qLm4rapcdGNdyfXJIaoSHwz+HD0XGbSZs5nT uO7oy5nOz72UWIozEg21mIuKEwF/G7HgWwMAAA== DLP-Filter: Pass X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t4M3JP3h023949 Content-Length: 2429 Lines: 76 EP-AA9D1F29B02341529D96C06444D8471D Hi Vinod >On Tue, May 19, 2015 at 05:00:27AM +0000, Maninder Singh wrote: >> EP-AA9D1F29B02341529D96C06444D8471D >Whats this, please sned patch ina proper format, git format-patch is your >friend, use it > This is auto generated no. from editor, so please ignore it, and i am resubmitting the patch, thanks for your feedback. >> >> Hi, >> Subject: [PATCH 1/1] dma/pl330.c : Initialize pl330 pointer after NULL check of pch pointer >patch title doesn't match expectations, use the right subsystem name, and >also please explain why yoy are doing this Ok according to comments resubmitting . Please check new patch if it is appropriate. because this patch is also generated by git, But i think editor does some malfunctioning. >> >> Signed-off-by: Maninder Singh >> Reviewed-By: Vaneet Narang >> --- >> drivers/dma/pl330.c | 4 +++- ---cut--- >> Thanks >> Maninder Singh >Nice signature! > >-- >~Vinod >From 76a6ef435065c10a0476038e8a08016878488dcb Mon Sep 17 00:00:00 2001 From: Maninder Singh Date: Mon, 18 May 2015 17:53:11 +0530 Subject: [PATCH 1/1] dmaengine: pl330: Initialize pl330 for pl330_prep_dma_memcpy after NULL check of pch Currently pch pointer is already dereferenced before NULL check and thus we are getting below warning: warn: variable dereferenced before check 'pch' So initialize struct pl330_dmac *pl330 after NULL check of dma_pl330_chan *pch. Signed-off-by: Maninder Singh Reviewed-by: Vaneet Narang --- drivers/dma/pl330.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c index a7d9d30..7e27144 100644 --- a/drivers/dma/pl330.c +++ b/drivers/dma/pl330.c @@ -2581,12 +2581,14 @@ pl330_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dst, { struct dma_pl330_desc *desc; struct dma_pl330_chan *pch = to_pchan(chan); - struct pl330_dmac *pl330 = pch->dmac; + struct pl330_dmac *pl330; int burst; if (unlikely(!pch || !len)) return NULL; + pl330 = pch->dmac; + desc = __pl330_prep_dma_memcpy(pch, dst, src, len); if (!desc) return NULL; -- 1.7.1 Thanks Maninder ............ ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?