Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756718AbbEVGDS (ORCPT ); Fri, 22 May 2015 02:03:18 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:55882 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750918AbbEVGDQ (ORCPT ); Fri, 22 May 2015 02:03:16 -0400 X-Listener-Flag: 11101 Message-ID: <1432274590.14396.40.camel@mtksdaap41> Subject: Re: [PATCH 4/5] clk: mediatek: Add subsystem clocks of MT8173 From: James Liao To: Daniel Kurtz CC: Matthias Brugger , Mike Turquette , Stephen Boyd , srv_heupstream , Ricky Liang , Rob Herring , Sascha Hauer , "open list:OPEN FIRMWARE AND..." , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Date: Fri, 22 May 2015 14:03:10 +0800 In-Reply-To: References: <1432192376-6712-1-git-send-email-jamesjj.liao@mediatek.com> <1432192376-6712-5-git-send-email-jamesjj.liao@mediatek.com> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1222 Lines: 33 Hi Daniel, On Fri, 2015-05-22 at 12:22 +0800, Daniel Kurtz wrote: > On Thu, May 21, 2015 at 3:12 PM, James Liao wrote: > > Most multimedia subsystem clocks will be accessed by multiple > > drivers, so it's a better way to manage these clocks in CCF. > > This patch adds clock support for MM, IMG, VDEC, VENC and VENC_LT > > subsystems. > > Is there a reason why this patch (or patch set) does not also include > definitions for the SCP_SYS, AUDIO and MFG_SYS clocks? Clocks of SCP_SYS is a workaround in our previous internal implementation. It should be replaced with new mtk-scpsys driver which implemented in pm_domain framework because they are used to power on/off subsystem domains. I had discussed with Sascha, and he said it not worth the overhead of CCF for clocks that are not shared by different units. As I know AUDIO and MFG clocks are only used by their own drivers. So I don't include them in this patch. Best regards, James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/