Date: Fri, 22 May 2015 08:27:23 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Josef Bacik <jbacik@fb.com>
Cc: a.p.zijlstra@chello.nl, mingo@redhat.com, acme@kernel.org,
        linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] perf-sched: add option to merge like comms to lat output
Message-ID: <20150522062722.GB4736@gmail.com>
References: <1432243504-21235-1-git-send-email-jbacik@fb.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1432243504-21235-1-git-send-email-jbacik@fb.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1250
Lines: 36


* Josef Bacik <jbacik@fb.com> wrote:

> Sometimes when debugging large multi-threaded applications it is helpful to
> collate all of the latency numbers into one bulk record to get an idea of what
> is going on.  This patch does this by merging any entries that belong to the
> same comm into one entry and then spits out those totals.  I've also sligtly

s/sligtly
  slightly

> changed the output so you can see how many threads were merged in the
> processing.  Thanks,

Useful feature!

> +	OPT_BOOLEAN('m', "merge-by-comm", &sched.merge_by_comm,
> +		    "merge like tasks together in the output"),

Could you please make this the default behavior, and then add an 
option to print more detailed latencies?

We generally try to output general overviews first, and then make it 
easy to also output a more detailed view of information. That's how 
perf report, perf top and perf stat (-d, -dd, -ddd) works in general.

Also, please post a before/after sample output in the changelog.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/