Message-ID: <555ED0CF.3060903@linux.intel.com>
Date: Fri, 22 May 2015 14:46:39 +0800
From: "Lu, Baolu" <baolu.lu@linux.intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: David Cohen <david.a.cohen@linux.intel.com>
CC: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        qiuxu.zhuo@intel.com
Subject: Re: [PATCH v2 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall
References: <1432260425-2350-1-git-send-email-baolu.lu@linux.intel.com> <20150522030954.GA28433@psi-dev26.jf.intel.com> <20150522031127.GB28433@psi-dev26.jf.intel.com>
In-Reply-To: <20150522031127.GB28433@psi-dev26.jf.intel.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1623
Lines: 48


On 05/22/2015 11:11 AM, David Cohen wrote:
> On Thu, May 21, 2015 at 08:09:54PM -0700, David Cohen wrote:
>> Hi,
>>
>> On Fri, May 22, 2015 at 10:07:05AM +0800, Lu Baolu wrote:
>>> Many drivers and modules depend on ULPI bus registeration to
>>> register ULPI interfaces and drivers. It's more appropriate
>>> to register ULPI bus in subsys_initcall instead of module_init.
>>>
>>> Kernel panic has been reported with some kind of kernel config.
>> Even though I agree subsys_initcall is better to register ulpi bus, it's
>> still no excuse to have kernel panic. What about ULPI bus being compiled
>> as module?

No kernel panic if ULPI is built as a module.

>> IMHO this is avoiding the proper kernel panic fix which should be
>> failing gracefully (or defer probe) from tusb1210 driver.
> Maybe I need to express myself better :)
> IMHO we should not consider work done with this patch only. It's still
> incomplete.

I am with you on that we should know the real problem.

I could go ahead with further debugging. Do you have any suggestions
about which direction should I go?

>
> Br, David

Thank you,
-Baolu

> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/