Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756421AbbEVGxv (ORCPT ); Fri, 22 May 2015 02:53:51 -0400 Received: from mail.skyhub.de ([78.46.96.112]:34572 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756165AbbEVGxu (ORCPT ); Fri, 22 May 2015 02:53:50 -0400 Date: Fri, 22 May 2015 08:53:46 +0200 From: Borislav Petkov To: "Luis R. Rodriguez" Cc: gregkh@linuxfoundation.org, davem@davemloft.net, clemens@ladisch.de, dmitry.torokhov@gmail.com, JBottomley@odin.com, airlied@linux.ie, mchehab@osg.samsung.com, herbert@gondor.apana.org.au, marcel@holtmann.org, gustavo@padovan.org, johan.hedberg@gmail.com, starvik@axis.com, jesper.nilsson@axis.com, kaloz@openwrt.org, khalasa@piap.pl, ohad@wizery.com, arnd@arndb.de, 3chas3@gmail.com, jslaby@suse.cz, cooloney@gmail.com, rpurdie@rpsys.net, j.anaszewski@samsung.com, pebolle@tiscali.nl, tiwai@suse.de, linux-kernel@vger.kernel.org Subject: Re: [RFC v1] tree-wide: remove "select FW_LOADER" uses Message-ID: <20150522065346.GA23022@pd.tnic> References: <1432241149-8762-1-git-send-email-mcgrof@do-not-panic.com> <20150521222129.GI3689@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150521222129.GI3689@pd.tnic> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2004 Lines: 45 On Fri, May 22, 2015 at 12:21:29AM +0200, Borislav Petkov wrote: > On Thu, May 21, 2015 at 01:45:49PM -0700, Luis R. Rodriguez wrote: > > The above history is just *one* set of reasons to remove all kernel > > "select FW_LOADER" entries. Another simple reason is that since > > FW_LOADER can only be disabled by an EXPERT and it defaults to y > > its now a superfluous select. We will ensure things build for you > > if using EXPERT but if you have selected EXPERT you should know > > what run time requirements you need. > > Couple of notes only: One thing I forgot last night: what about randconfigs? All that functionality which selects FW_LOADER, won't boot anymore, right? I mean, there are provisions to build fine even with FW_LOADER unset but if you want to boot-test those kernels, you will artificially fail due to missing request_firmware* things... Yap, just triggered one: $ make randconfig; grep -E "(MICROCODE|FW_LOADER)" .config scripts/kconfig/conf --randconfig Kconfig KCONFIG_SEED=0xE14FBE97 warning: (USB_OTG_FSM && FSL_USB2_OTG && USB_MV_OTG) selects USB_OTG which has unmet direct dependencies (USB_SUPPORT && USB && PM) warning: (USB_OTG_FSM && FSL_USB2_OTG && USB_MV_OTG) selects USB_OTG which has unmet direct dependencies (USB_SUPPORT && USB && PM) warning: (SND_SOC_INTEL_BYTCR_RT5640_MACH && SND_SOC_INTEL_CHT_BSW_RT5672_MACH && SND_SOC_INTEL_CHT_BSW_RT5645_MACH) selects SND_SST_IPC_ACPI which has unmet direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC && ACPI) # # configuration written to .config # CONFIG_MICROCODE=m CONFIG_MICROCODE_INTEL=y CONFIG_MICROCODE_AMD=y CONFIG_MICROCODE_OLD_INTERFACE=y # CONFIG_FW_LOADER is not set -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/