Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932329AbbEVH7F (ORCPT ); Fri, 22 May 2015 03:59:05 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45890 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754712AbbEVH67 (ORCPT ); Fri, 22 May 2015 03:58:59 -0400 Message-ID: <555EE1C2.6060601@suse.de> Date: Fri, 22 May 2015 09:58:58 +0200 From: Hannes Reinecke User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: "Nicholas A. Bellinger" , target-devel CC: linux-scsi , linux-kernel , Christoph Hellwig , Nicholas Bellinger Subject: Re: [PATCH 3/4] target: Drop se_lun->lun_active for existing percpu lun_ref References: <1432278417-29994-1-git-send-email-nab@daterainc.com> <1432278417-29994-4-git-send-email-nab@daterainc.com> In-Reply-To: <1432278417-29994-4-git-send-email-nab@daterainc.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1177 Lines: 31 On 05/22/2015 09:06 AM, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > With se_port_t and t10_alua_tg_pt_gp_member being absored into se_lun, > there is no need for an extra atomic_t based reference count for PR > ALL_TG_PT=1 and ALUA access state transition. > > Go ahead and use the existing percpu se_lun->lun_ref instead, and > convert the two special cases to percpu_ref_tryget_live() to avoid > se_lun if transport_clear_lun_ref() has already been invoked to > shutdown the se_lun. > > Cc: Christoph Hellwig > Signed-off-by: Nicholas Bellinger > --- Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: F. Imend?rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG N?rnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/