Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756913AbbEVIAU (ORCPT ); Fri, 22 May 2015 04:00:20 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45956 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756869AbbEVIAP (ORCPT ); Fri, 22 May 2015 04:00:15 -0400 Message-ID: <555EE20D.1070307@suse.de> Date: Fri, 22 May 2015 10:00:13 +0200 From: Hannes Reinecke User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: "Nicholas A. Bellinger" , target-devel CC: linux-scsi , linux-kernel , Christoph Hellwig , Nicholas Bellinger Subject: Re: [PATCH 4/4] target: Drop unnecessary core_tpg_register TFO parameter References: <1432278417-29994-1-git-send-email-nab@daterainc.com> <1432278417-29994-5-git-send-email-nab@daterainc.com> In-Reply-To: <1432278417-29994-5-git-send-email-nab@daterainc.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1225 Lines: 33 On 05/22/2015 09:06 AM, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > This patch drops unnecessary target_core_fabric_ops parameter usage > for core_tpg_register() during fabric driver TFO->fabric_make_tpg() > se_portal_group creation callback execution. > > Instead, use the existing se_wwn->wwn_tf->tf_ops pointer to ensure > fabric driver is really using the same TFO provided at module_init > time. > > Also go ahead and drop the forward TFO declarations tree-wide, and > handling the special case for iscsi-target discovery TPG. > > Cc: Christoph Hellwig > Signed-off-by: Nicholas Bellinger > --- Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: F. Imend?rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG N?rnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/