Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756495AbbEVIE4 (ORCPT ); Fri, 22 May 2015 04:04:56 -0400 Received: from mga14.intel.com ([192.55.52.115]:4674 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751688AbbEVIEs convert rfc822-to-8bit (ORCPT ); Fri, 22 May 2015 04:04:48 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,474,1427785200"; d="scan'208";a="714110065" From: "Drokin, Oleg" To: Michael Shuey CC: Joe Perches , "" , "" , "" , "" , "hpdd-discuss@lists.01.org" , "" Subject: Re: [PATCH v4 10/13] staging: lustre: lnet: lnet: checkpatch.pl fixes Thread-Topic: [PATCH v4 10/13] staging: lustre: lnet: lnet: checkpatch.pl fixes Thread-Index: AQHQk/93XA0p7K7liUSlz4yf9IRFEZ2HX5EAgAANVYCAAKxagA== Date: Fri, 22 May 2015 08:04:39 +0000 Message-ID: <5A9267C2-39F8-423C-967B-80055F6070AC@intel.com> References: <1432237849-53947-1-git-send-email-shuey@purdue.edu> <1432237849-53947-11-git-send-email-shuey@purdue.edu> <1432242004.20840.68.camel@perches.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.20.199] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2125 Lines: 44 Removal of lustre-added typedefs is worthwhile, actually. I scraped the surface some time ago, but could not complete it back then. On May 21, 2015, at 5:47 PM, Michael Shuey wrote: > I've been killing off a *lot* of checkpatch warnings, and I'm probably getting a tad overzealous. I'll drop these from the patch series next time I rebase, and avoid doing this in the future. Thanks for the input. > > Any suggestions on other checkpatch warnings? Most of what remains are "don't introduce new typedefs" warnings - should these be removed as well, or am I safe to leave these? I ask because these changes will be huge, and are unlikely to improve readability (but I don't know where the kernel community stands on having billions of typedefs everywhere. > > -- > Mike Shuey > > On Thu, May 21, 2015 at 5:00 PM, Joe Perches wrote: > On Thu, 2015-05-21 at 15:50 -0400, Mike Shuey wrote: > > Fix many checkpatch.pl warnings. > [] > > diff --git a/drivers/staging/lustre/lnet/lnet/acceptor.c b/drivers/staging/lustre/lnet/lnet/acceptor.c > [] > > @@ -99,38 +99,42 @@ lnet_connect_console_error(int rc, lnet_nid_t peer_nid, > > switch (rc) { > > /* "normal" errors */ > > case -ECONNREFUSED: > > - CNETERR("Connection to %s at host %pI4h on port %d was refused: check that Lustre is running on that node.\n", > > - libcfs_nid2str(peer_nid), > > - &peer_ip, peer_port); > > + CNETERR( > > + "Connection to %s at host %pI4h on port %d was refused: check that Lustre is running on that node.\n", > > + libcfs_nid2str(peer_nid), &peer_ip, peer_port); > > These are not improvements and checkpatch messages aren't dicta. > > Please don't convert code unless the conversion makes it better > for a human reader. > > These don't. > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/