Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756609AbbEVIIw (ORCPT ); Fri, 22 May 2015 04:08:52 -0400 Received: from mga09.intel.com ([134.134.136.24]:58599 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755450AbbEVIIq convert rfc822-to-8bit (ORCPT ); Fri, 22 May 2015 04:08:46 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,474,1427785200"; d="scan'208";a="733590202" From: "Drokin, Oleg" To: Julia Lawall CC: Michael Shuey , Joe Perches , "" , "" , "" , "" , "" , "" Subject: Re: [PATCH v4 10/13] staging: lustre: lnet: lnet: checkpatch.pl fixes Thread-Topic: [PATCH v4 10/13] staging: lustre: lnet: lnet: checkpatch.pl fixes Thread-Index: AQHQlE0l9huCFEcf6U2xtGRkHfz1+Z2IGckA Date: Fri, 22 May 2015 08:08:44 +0000 Message-ID: <15C0AFDB-CA69-40E5-B65E-C559A5B5CE47@intel.com> References: <1432237849-53947-1-git-send-email-shuey@purdue.edu> <1432237849-53947-11-git-send-email-shuey@purdue.edu> <1432242004.20840.68.camel@perches.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.20.199] Content-Type: text/plain; charset="us-ascii" Content-ID: <93FB9CBE0EB68446AD38F050EC6E269A@intel.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1633 Lines: 34 On May 22, 2015, at 1:06 AM, Julia Lawall wrote: > On Thu, 21 May 2015, Michael Shuey wrote: > >> That's a task (of many) I've been putting on the back burner until the code >> is cleaner. It's also a HUGE change, since there are debug macros >> everywhere, and they all check a #define'd mask to see if they should fire, >> and the behavior is likely governed by parts of the lustre user land tools >> as well. >> >> Suggestions are welcome. Do other parts of the linux kernel define complex >> debugging macros like these, or is this a lustre-ism? Any suggestions on >> how to handle this more in line with existing drivers? > > Once you decide what to do, you can use Coccinelle to make the changes for > you. So you shouldn't be put off by the number of code sites to change. > > The normal functions are pr_err, pr_warn, etc. Perhaps you can follow > Joe's suggestions if you really need something more complicated. Ideally leaving CERROR/CDEBUG in Lustre would be desirable from my perspective. It allows you fine grained control about what to collect and what to output into a (quite finite) kernel buffer (and over a quite slow serial console) and at the same time if you need more info, there's a buffer you can fetch separately that can grow much bigger and there's even a way to run a special daemon to scrub the buffer eagerly so none of it is lost. Bye, Oleg-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/