Message-ID: <1432284459.27695.41.camel@x220>
Subject: Re: [PATCH 4/5] phy: cygnus: pcie: Add Cygnus PCIe PHY support
From: Paul Bolle <pebolle@tiscali.nl>
To: Ray Jui <rjui@broadcom.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>, linux-kernel@vger.kernel.org,
        "JD (Jiandong) Zheng" <jdzheng@broadcom.com>,
        Arun Parameswaran <arunp@broadcom.com>,
        bcm-kernel-feedback-list@broadcom.com
Date: Fri, 22 May 2015 10:47:39 +0200
In-Reply-To: <555E6FFC.2080309@broadcom.com>
References: <1432085014-20758-1-git-send-email-rjui@broadcom.com>
		 <1432085014-20758-5-git-send-email-rjui@broadcom.com>
	 <1432194775.21715.118.camel@x220> <555E6FFC.2080309@broadcom.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 771
Lines: 20

On Thu, 2015-05-21 at 16:53 -0700, Ray Jui wrote:
> Yes, I'll change the PCIe PHY driver to tristate in the Kconfig. Thanks!

To continue the discussion started in 2/5: this is my main beef with
built-in only code using module specific macros. It forces the reader of
the patch, and the code if it's already in the tree, to know the
intentions of the author. Did the author intend the code to be built-in
only or not?

And since most people appear not to be clairvoyant that's kind of hard
to do for most of us.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/