Message-ID: <1432285597.27695.55.camel@x220>
Subject: Re: [RFC v1] tree-wide: remove "select FW_LOADER" uses
From: Paul Bolle <pebolle@tiscali.nl>
To: Takashi Iwai <tiwai@suse.de>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>, Borislav Petkov <bp@alien8.de>,
        "Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        "David S. Miller" <davem@davemloft.net>, clemens@ladisch.de,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>, JBottomley@odin.com,
        David Airlie <airlied@linux.ie>,
        Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Marcel Holtmann <marcel@holtmann.org>,
        "Gustavo F. Padovan" <gustavo@padovan.org>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        Mikael Starvik <starvik@axis.com>,
        Jesper Nilsson <jesper.nilsson@axis.com>,
        Imre Kaloz <kaloz@openwrt.org>, khalasa@piap.pl, ohad@wizery.com,
        Arnd Bergmann <arnd@arndb.de>, 3chas3@gmail.com,
        Jiri Slaby <jslaby@suse.cz>, Bryan Wu <cooloney@gmail.com>,
        Richard Purdie <rpurdie@rpsys.net>,
        Jacek Anaszewski <j.anaszewski@samsung.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Date: Fri, 22 May 2015 11:06:37 +0200
In-Reply-To: <s5h7fs1gfxl.wl-tiwai@suse.de>
References: <1432241149-8762-1-git-send-email-mcgrof@do-not-panic.com>
	 <20150521222129.GI3689@pd.tnic> <20150522065346.GA23022@pd.tnic>
	 <CAMuHMdVVi3Sf22wuNRU3U4LkvrKKSufC+wFxa78mtAWa48fK5w@mail.gmail.com>
	 <1432282668.27695.24.camel@x220> <s5h7fs1gfxl.wl-tiwai@suse.de>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1773
Lines: 45

On Fri, 2015-05-22 at 10:44 +0200, Takashi Iwai wrote:
> At Fri, 22 May 2015 10:17:48 +0200,
> Paul Bolle wrote:
> > Luis also tried to explain to me that disabling FW_LOADER shouldn't make
> > the build fail. (And, of course, we could decide to not care about
> > randconfig builds that have EXPERT set. Maybe we could even special case
> > EXPERT in randconfig. But that would make randconfig builds less useful.
> > That's a separate issue, anyhow.)
> 
> But FW_LOADER is a tristate, so it might be inconsistent if selected
> randomly?  Luis' patch doesn't add depends but just removes select.

include/linux/firmware.h contains:
    #if defined(CONFIG_FW_LOADER) || (defined(CONFIG_FW_LOADER_MODULE) && defined(MODULE)
    int request_firmware(const struct firmware **fw, const char *name,
                         struct device *device);
    [...]
    #else
    static inline int request_firmware(const struct firmware **fw,
                                       const char *name,
                                       struct device *device)
    {
            return -EINVAL;
    }
    [...]
    #endif

So I _think_ the build should be fine.

But, in case of built-in users of request_firmware() and friends,
actually using that build might not go as expected. But if you set
EXPERT and disable FW_LOADER, or as you point out, set it to 'm', you
own the pieces when things break, don't you?

But now I'm doing Luis' job. I didn't sign off on that patch! So let's
hope Luis thought of all the corner cases.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/