Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757120AbbEVJ4o (ORCPT ); Fri, 22 May 2015 05:56:44 -0400 Received: from cantor2.suse.de ([195.135.220.15]:52787 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755640AbbEVJ4k (ORCPT ); Fri, 22 May 2015 05:56:40 -0400 Date: Fri, 22 May 2015 11:56:34 +0200 Message-ID: From: Takashi Iwai To: Paul Bolle Cc: Takashi Iwai , Geert Uytterhoeven , Borislav Petkov , "Luis R. Rodriguez" , Greg KH , "David S. Miller" , clemens@ladisch.de, Dmitry Torokhov , JBottomley@odin.com, David Airlie , Mauro Carvalho Chehab , Herbert Xu , Marcel Holtmann , "Gustavo F. Padovan" , Johan Hedberg , Mikael Starvik , Jesper Nilsson , Imre Kaloz , khalasa@piap.pl, ohad@wizery.com, Arnd Bergmann , 3chas3@gmail.com, Jiri Slaby , Bryan Wu , Richard Purdie , Jacek Anaszewski , "linux-kernel@vger.kernel.org" Subject: Re: [RFC v1] tree-wide: remove "select FW_LOADER" uses In-Reply-To: <1432285597.27695.55.camel@x220> References: <1432241149-8762-1-git-send-email-mcgrof@do-not-panic.com> <20150521222129.GI3689@pd.tnic> <20150522065346.GA23022@pd.tnic> <1432282668.27695.24.camel@x220> <1432285597.27695.55.camel@x220> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2189 Lines: 59 At Fri, 22 May 2015 11:06:37 +0200, Paul Bolle wrote: > > On Fri, 2015-05-22 at 10:44 +0200, Takashi Iwai wrote: > > At Fri, 22 May 2015 10:17:48 +0200, > > Paul Bolle wrote: > > > Luis also tried to explain to me that disabling FW_LOADER shouldn't make > > > the build fail. (And, of course, we could decide to not care about > > > randconfig builds that have EXPERT set. Maybe we could even special case > > > EXPERT in randconfig. But that would make randconfig builds less useful. > > > That's a separate issue, anyhow.) > > > > But FW_LOADER is a tristate, so it might be inconsistent if selected > > randomly? Luis' patch doesn't add depends but just removes select. > > include/linux/firmware.h contains: > #if defined(CONFIG_FW_LOADER) || (defined(CONFIG_FW_LOADER_MODULE) && defined(MODULE) > int request_firmware(const struct firmware **fw, const char *name, > struct device *device); > [...] > #else > static inline int request_firmware(const struct firmware **fw, > const char *name, > struct device *device) > { > return -EINVAL; > } > [...] > #endif > > So I _think_ the build should be fine. Ah, OK, that would work. > But, in case of built-in users of request_firmware() and friends, > actually using that build might not go as expected. But if you set > EXPERT and disable FW_LOADER, or as you point out, set it to 'm', you > own the pieces when things break, don't you? Yeah, I'm not against it, too. My concern is only about the silent breakage. Thinking of this again, I also concluded that removing the mostly superfluous "select FW_LOADER" would make things easier in the end. > But now I'm doing Luis' job. I didn't sign off on that patch! So let's > hope Luis thought of all the corner cases. Heh, let's hope we all reach to a happy end. thanks, Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/