Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757088AbbEVKC5 (ORCPT ); Fri, 22 May 2015 06:02:57 -0400 Received: from mail-wg0-f47.google.com ([74.125.82.47]:35622 "EHLO mail-wg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755795AbbEVKCz (ORCPT ); Fri, 22 May 2015 06:02:55 -0400 Date: Fri, 22 May 2015 12:02:52 +0200 From: Thierry Reding To: Mikko Perttunen Cc: Arto Merilainen , Mikko Perttunen , linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, achew@nvidia.com, srasal@nvidia.com, dnibade@nvidia.com Subject: Re: [PATCH 3/4] drm/tegra: Add VIC support Message-ID: <20150522100251.GC16507@ulmo> References: <1432214425-27137-1-git-send-email-amerilainen@nvidia.com> <1432214425-27137-4-git-send-email-amerilainen@nvidia.com> <555DEE5F.2060100@nvidia.com> <555DF576.7070307@nvidia.com> <555DFD48.4000609@kapsi.fi> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qjNfmADvan18RZcF" Content-Disposition: inline In-Reply-To: <555DFD48.4000609@kapsi.fi> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2311 Lines: 60 --qjNfmADvan18RZcF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 21, 2015 at 06:44:08PM +0300, Mikko Perttunen wrote: > On 05/21/2015 06:10 PM, Arto Merilainen wrote: > >... > >>>+ > >>>+ vic->rst =3D devm_reset_control_get(dev, "vic03"); > >> > >>I might prefer just "vic" as the clock/reset name. The name is often > >>used as a sort of "role" for the clock/reset for the device, not > >>necessarily the raw name of the "correct" clock/reset. > >> > > > >I considered that - but I then noticed that > >drivers/clk/tegra/clk-tegra124.c was already using vic03 variant. I can > >write a patch for changing that too. >=20 > Well, the two can be different; the clock-name in device tree kind of mea= ns > "string that i use to refer to a clock that powers the VIC unit". It's not > really a big deal though, both ways are used in DT bindings. I'll insist on calling this vic in the clock-names property. The 03 is as far as I can tell an encoding of the version number, so if you want to call this vic04 in some future version we'll have to needlessly patch the driver. Thierry --qjNfmADvan18RZcF Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVXv7LAAoJEN0jrNd/PrOhS/AP/A1qevrmwHmgtqyU5Oxdj9lP VZ3DD1Tf6jhOsDk79vGSEP0oegbCll+3byxWOO2CyoFp0ZlqAhdEh0utdE/e8TlR FbEJt86DXPHQIewjWVJND5PDNn/6MGVNh8PKiQPkSkaP6p40xyi+J/1nVFcF62bA vV1XTMvF/PkHQOBazOjN7za6sljOIb7TLlNceb+XsoR5o+s21AoyDBgChDfDh0n+ a/m7Hfg5dircyHpR5gezxG0dMi4PPQx0PHO02SRl4zAOPJ3oInQKxhBpkc7b9jne M1ATZkL/hZcLiirj9z3aTJD6t0bRG97v0amDd996QSdgDWL3jxbk1MxYkShlrqg+ Ha5/0CvZ7rzOecFJ63uSdOVmVDBye7yYgRCZ5vFY8s5GSueTRZZRyK8NCDYOzYUC F8QsC7nmkqBIIbJoO4vsawAZ2S3qtu5ZeOmRXIUzHj4oxZhXrhzji1yr7VkaYbrn a8oBhPnGcZr9iSpvEPh5aVANH/Lv76FGE3leOIHlxThluiOn4+DkauNWIkeJ89cf 3HBv+MCoDvvzXfZP21hszDR6UwFb87Om+zcmj5VTf+B0/0+fMINy/+GTi9fgIvPe T4vvYxXTESo426KzI+7wEpvASTiJ6Y4uroWh1Zfav78QYtRGMHLYiiMGn8C+lYZm l0W9G9dEUszWynxDyzUm =e0Az -----END PGP SIGNATURE----- --qjNfmADvan18RZcF-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/