Message-ID: <555F0107.6030102@sandisk.com>
Date: Fri, 22 May 2015 12:12:23 +0200
From: Bart Van Assche <bart.vanassche@sandisk.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: "Nicholas A. Bellinger" <nab@daterainc.com>,
        target-devel <target-devel@vger.kernel.org>
CC: linux-scsi <linux-scsi@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Hannes Reinecke <hare@suse.de>, "Christoph Hellwig" <hch@lst.de>,
        Sagi Grimberg <sagig@mellanox.com>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Nicholas Bellinger <nab@linux-iscsi.org>
Subject: Re: [PATCH-v2 2/9] target/pr: Use atomic bitop for se_dev_entry->pr_reg
 reservation check
References: <1432275071-28882-1-git-send-email-nab@daterainc.com>
 <1432275071-28882-3-git-send-email-nab@daterainc.com>
In-Reply-To: <1432275071-28882-3-git-send-email-nab@daterainc.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2015 10:12:27.2082
 (UTC)
X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.173];Helo=[milsmgep12.sandisk.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR02MB286
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1254
Lines: 38

On 05/22/15 08:11, Nicholas A. Bellinger wrote:
> diff --git a/include/target/target_core_base.h b/include/target/target_core_base.h
> index e2c0eaf..def5bc8 100644
> --- a/include/target/target_core_base.h
> +++ b/include/target/target_core_base.h
> @@ -638,7 +638,6 @@ struct se_lun_acl {
>   };
>
>   struct se_dev_entry {
> -	bool			def_pr_registered;
>   	/* See transport_lunflags_table */
>   	u32			lun_flags;
>   	u32			mapped_lun;
> @@ -655,7 +654,8 @@ struct se_dev_entry {
>   	struct se_node_acl	*se_node_acl;
>   	struct se_lun_acl __rcu	*se_lun_acl;
>   	spinlock_t		ua_lock;
> -	struct se_lun		*se_lun;
> +	struct se_lun __rcu	*se_lun;
> +	unsigned long		pr_reg;
>   	struct list_head	alua_port_list;
>   	struct list_head	ua_list;
>   	struct hlist_node	link;

Hello Nic,

This change causes the "se_lun = deve->se_lun" assignment in 
transport_lookup_cmd_lun() to assign an RCU pointer to a non-RCU 
pointer. Shouldn't such an assignment be protected via rcu_dereference() ?

Thanks,

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/