Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757168AbbEVKNg (ORCPT ); Fri, 22 May 2015 06:13:36 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:11503 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755852AbbEVKNd (ORCPT ); Fri, 22 May 2015 06:13:33 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Fri, 22 May 2015 03:11:29 -0700 Message-ID: <555F0145.8040004@nvidia.com> Date: Fri, 22 May 2015 13:13:25 +0300 From: Arto Merilainen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Thierry Reding , Mikko Perttunen CC: Mikko Perttunen , , , , , , Subject: Re: [PATCH 3/4] drm/tegra: Add VIC support References: <1432214425-27137-1-git-send-email-amerilainen@nvidia.com> <1432214425-27137-4-git-send-email-amerilainen@nvidia.com> <555DEE5F.2060100@nvidia.com> <555DF576.7070307@nvidia.com> <555DFD48.4000609@kapsi.fi> <20150522100251.GC16507@ulmo> In-Reply-To: <20150522100251.GC16507@ulmo> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.21.177.47] X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL101.nvidia.com (10.26.138.13) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1472 Lines: 39 Hi Thierry, On 05/22/2015 01:02 PM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Thu, May 21, 2015 at 06:44:08PM +0300, Mikko Perttunen wrote: >> On 05/21/2015 06:10 PM, Arto Merilainen wrote: >>> ... >>>>> + >>>>> + vic->rst = devm_reset_control_get(dev, "vic03"); >>>> >>>> I might prefer just "vic" as the clock/reset name. The name is often >>>> used as a sort of "role" for the clock/reset for the device, not >>>> necessarily the raw name of the "correct" clock/reset. >>>> >>> >>> I considered that - but I then noticed that >>> drivers/clk/tegra/clk-tegra124.c was already using vic03 variant. I can >>> write a patch for changing that too. >> >> Well, the two can be different; the clock-name in device tree kind of means >> "string that i use to refer to a clock that powers the VIC unit". It's not >> really a big deal though, both ways are used in DT bindings. > > I'll insist on calling this vic in the clock-names property. The 03 is > as far as I can tell an encoding of the version number, so if you want > to call this vic04 in some future version we'll have to needlessly > patch the driver. I agree, this is better without 04 postfix and I will remove it in the next version. - Arto -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/