Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1945983AbbEVKag (ORCPT ); Fri, 22 May 2015 06:30:36 -0400 Received: from mail-bl2on0087.outbound.protection.outlook.com ([65.55.169.87]:47546 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1945925AbbEVKae (ORCPT ); Fri, 22 May 2015 06:30:34 -0400 Authentication-Results: spf=pass (sender IP is 63.163.107.172) smtp.mailfrom=sandisk.com; daterainc.com; dkim=none (message not signed) header.d=none; X-AuditID: ac160a68-f790b6d00000123b-66-555f01c6dd11 Message-ID: <555F01C3.3020301@sandisk.com> Date: Fri, 22 May 2015 12:15:31 +0200 From: Bart Van Assche User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: "Nicholas A. Bellinger" , target-devel CC: linux-scsi , linux-kernel , Hannes Reinecke , "Christoph Hellwig" , Sagi Grimberg , "Paul E. McKenney" , Nicholas Bellinger Subject: Re: [PATCH-v2 0/9] target: se_node_acl + se_lun RCU conversions References: <1432275071-28882-1-git-send-email-nab@daterainc.com> In-Reply-To: <1432275071-28882-1-git-send-email-nab@daterainc.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrIIsWRmVeSWpSXmKPExsWyRoxnke4xxvhQg/+XjC32LJrEZLFy9VEm i8u75rBZdF/fwWbx6twKJou21WcYLd5u/s5qcaPtAZtF69K3TA6cHks/rGL2uL/9CJPHg0Ob WTx232xg83g2/TCTx+bT1R6fN8kFsEdx2aSk5mSWpRbp2yVwZew4/Ju54H1hxZoN75kbGB+n dDFyckgImEjMbV7NBGGLSVy4t56ti5GLQ0jgBKPEjq6VTBDODkaJeft3s8F0HH7wnAUisZlR onfWCdYuRg4OXgEtidWbLUBqWARUJSbMamEEsdkEjCS+vZ/JAmKLCoRJTPv9nBXE5hUQlDg5 8wlYXEQgTuLk7p2MIDOZBeYySVz7uRvsJGEBD4mtcw4zg9hCAo4SxzbOYgexOQWcJOZe+QS2 gFnAQOLIojmsELa8xPa3c5ghDv3KKvFjljREr7rEySXzmSYwisxCsnsWkvZZSNoXMDKvYhTL zcwpzk1PLTA01CtOzEvJLM7WS87P3cQIjjhgcDJunWR+iFGAg1GJh9fgYFyoEGtiWXFl7iFG CQ5mJRHet9+AQrwpiZVVqUX58UWlOanFhxilOViUxHl7c3VChQTSE0tSs1NTC1KLYLJMHJxS DYwMWq59/IwxApu6FVqfH74cl7HUpyN5o8GOTbZynHoiuhxPdT/E3Js5ubem/I6EceCN6TZi mm5rDW9sTfxwx+dZb/zRsH9GsTNKWT1FXLvV000fTHYuaa62OduvOFtu2dtz07d+XyOfdLTA QLnr6SbmRyXJJ80C29aYWUwJVPt9tMQ2xLdaTYmlOCPRUIu5qDgRALcAs+m0AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprKLMWRmVeSWpSXmKPExsXCtZEjRfcYY3yowf5DqhZ7Fk1isli5+iiT xeVdc9gsuq/vYLN4dW4Fk0Xb6jOMFm83f2e1uNH2gM2idelbJgdOj6UfVjF73N9+hMnjwaHN LB67bzaweTybfpjJY/Ppao/Pm+QC2KO4bFJSczLLUov07RK4MnYc/s1c8L6wYs2G98wNjI9T uhg5OSQETCQOP3jOAmGLSVy4t56ti5GLQ0hgI6NE074lQAkODl4BLYnVmy1AalgEVCUmzGph BLHZBIwkvr2fCdYrKhAmMe33c1YQm1dAUOLkzCdAcXYOEYF4iesqIBOZBZYwSTStamIDKREW 8JDYOucwM4gtJOAocWzjLHYQm1PASWLulU9g45kF9CR2XP/FCmHLS2x/O4d5AiP/LCQbZiEp m4WkbAEj8ypGsdzMnOLc9MwCQ0O94sS8lMzibL3k/NxNjOCA54zcwfh0ovkhRiYOTqkGRsVb x8qff0n5fvm1jEz///QL7Mcum19//rnoYLNYdWvJtFrneofejrUizkGbovIK9/zy331Y4/Tx YIZdNfe+ZDSYGh6wEFzyVE9bynhZyV2G7N6UeQU295hFCyvDb8y2Wctjvb63q7fzZ5XnbrWP Z/rS/m9r5H12+RWjZPXi7ftOS+lLhEsUKrEUZyQaajEXFScCADnbcq0oAgAA X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11OLC009;1:la4l0FuozLm8UvIu4gcUPOrz/2jjwmkOp4src7S0tATlJxmPVVfKvduGfxyor78bukTg04d825PLHgANwfQDM7aLpPBqAY/RMEbUm4FSnJlAF89AYn8agfW6HrDPobMX/8ZE7LCeSk1DYpVrlVAZf8qQe1AB1wbF1NZbcG9VOf01vywECQv2iOySQEmH0yLeb75c31ogmkjCgfll+gfeusa/X9gA/rvEAyX9cRsWOduXtD60BsV9Ssp7Ev36Pbh8QV1uB/9C88yeZp+dOUyARSgWUuG1Vr+qwZGJMzezfjk= X-Forefront-Antispam-Report: CIP:63.163.107.172;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(979002)(6009001)(438002)(199003)(479174004)(189002)(24454002)(2950100001)(68736005)(77096005)(80316001)(50466002)(83506001)(62966003)(46102003)(86362001)(77156002)(59896002)(92566002)(106466001)(87936001)(33656002)(64126003)(76176999)(50986999)(54356999)(87266999)(65816999)(23746002)(97736004)(5001770100001)(36756003)(5001920100001)(189998001)(4001350100001)(65956001)(69596002)(5001830100001)(47776003)(5001860100001)(5001960100002)(65806001)(4001540100001)(81156007)(64706001)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR0201MB1036;H:milsmgep11.sandisk.com;FPR:;SPF:Pass;PTR:ErrorRetry;A:1;MX:1;LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0201MB1036; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(520002)(3002001);SRVR:CY1PR0201MB1036;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0201MB1036; X-Forefront-PRVS: 058441C12A X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2015 10:15:34.9920 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.172];Helo=[milsmgep11.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0201MB1036 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 14624 Lines: 201 On 05/22/15 08:11, Nicholas A. Bellinger wrote: > Here is -v2 series for converting LIO target se_node_acl + se_lun > mapping tables from fixed size arrays to dynamic RCU hlist_heads. The full list of new sparse warnings introduced by this patch series for source files under drivers/target is as follows: $ make M=drivers/target C=2 CHECK drivers/target/target_core_configfs.c CC [M] drivers/target/target_core_configfs.o CHECK drivers/target/target_core_device.c drivers/target/target_core_device.c:89:24: warning: incorrect type in assignment (different address spaces) drivers/target/target_core_device.c:89:24: expected struct se_lun *se_lun drivers/target/target_core_device.c:89:24: got struct se_lun [noderef] *se_lun drivers/target/target_core_device.c:90:32: warning: incorrect type in assignment (different address spaces) drivers/target/target_core_device.c:90:32: expected struct se_lun *se_lun drivers/target/target_core_device.c:90:32: got struct se_lun [noderef] *se_lun drivers/target/target_core_device.c:130:24: warning: incorrect type in assignment (different address spaces) drivers/target/target_core_device.c:130:24: expected struct se_device *se_dev drivers/target/target_core_device.c:130:24: got struct se_device [noderef] *lun_se_dev drivers/target/target_core_device.c:132:13: warning: incorrect type in assignment (different address spaces) drivers/target/target_core_device.c:132:13: expected struct se_device *dev drivers/target/target_core_device.c:132:13: got struct se_device [noderef] *lun_se_dev drivers/target/target_core_device.c:158:33: warning: incorrect type in assignment (different address spaces) drivers/target/target_core_device.c:158:33: expected struct se_lun *tmr_lun drivers/target/target_core_device.c:158:33: got struct se_lun [noderef] *se_lun drivers/target/target_core_device.c:159:32: warning: incorrect type in assignment (different address spaces) drivers/target/target_core_device.c:159:32: expected struct se_lun *se_lun drivers/target/target_core_device.c:159:32: got struct se_lun [noderef] *se_lun drivers/target/target_core_device.c:160:24: warning: incorrect type in assignment (different address spaces) drivers/target/target_core_device.c:160:24: expected struct se_lun *se_lun drivers/target/target_core_device.c:160:24: got struct se_lun [noderef] *se_lun drivers/target/target_core_device.c:175:24: warning: incorrect type in assignment (different address spaces) drivers/target/target_core_device.c:175:24: expected struct se_device *se_dev drivers/target/target_core_device.c:175:24: got struct se_device [noderef] *lun_se_dev drivers/target/target_core_device.c:176:25: warning: incorrect type in assignment (different address spaces) drivers/target/target_core_device.c:176:25: expected struct se_device *tmr_dev drivers/target/target_core_device.c:176:25: got struct se_device [noderef] *lun_se_dev drivers/target/target_core_device.c:219:21: warning: incorrect type in assignment (different address spaces) drivers/target/target_core_device.c:219:21: expected struct se_lun *lun drivers/target/target_core_device.c:219:21: got struct se_lun [noderef] *se_lun drivers/target/target_core_device.c:247:55: warning: incorrect type in argument 1 (different address spaces) drivers/target/target_core_device.c:247:55: expected struct se_lun * drivers/target/target_core_device.c:247:55: got struct se_lun [noderef] *se_lun drivers/target/target_core_device.c:335:34: error: incompatible types in comparison expression (different address spaces) drivers/target/target_core_device.c:421:45: warning: incorrect type in argument 1 (different address spaces) drivers/target/target_core_device.c:421:45: expected struct se_device * drivers/target/target_core_device.c:421:45: got struct se_device [noderef] *lun_se_dev drivers/target/target_core_device.c:438:33: error: incompatible types in comparison expression (different address spaces) drivers/target/target_core_device.c:519:6: warning: symbol 'se_dev_check_wce' was not declared. Should it be static? drivers/target/target_core_device.c:643:48: warning: incorrect type in argument 1 (different address spaces) drivers/target/target_core_device.c:643:48: expected struct se_device * drivers/target/target_core_device.c:643:48: got struct se_device [noderef] *lun_se_dev drivers/target/target_core_device.c:793:31: warning: incorrect type in assignment (different address spaces) drivers/target/target_core_device.c:793:31: expected struct se_device [noderef] *lun_se_dev drivers/target/target_core_device.c:793:31: got struct se_device *[assigned] dev CC [M] drivers/target/target_core_device.o CHECK drivers/target/target_core_fabric_configfs.c CC [M] drivers/target/target_core_fabric_configfs.o CHECK drivers/target/target_core_fabric_lib.c CC [M] drivers/target/target_core_fabric_lib.o CHECK drivers/target/target_core_hba.c CC [M] drivers/target/target_core_hba.o CHECK drivers/target/target_core_pr.c drivers/target/target_core_pr.c:1412:45: warning: incorrect type in initializer (different address spaces) drivers/target/target_core_pr.c:1412:45: expected struct se_lun_acl *lun_acl drivers/target/target_core_pr.c:1412:45: got struct se_lun_acl [noderef] *se_lun_acl drivers/target/target_core_pr.c:1435:17: warning: incorrect type in assignment (different address spaces) drivers/target/target_core_pr.c:1435:17: expected struct se_lun_acl *lun_acl drivers/target/target_core_pr.c:1435:17: got struct se_lun_acl [noderef] *se_lun_acl drivers/target/target_core_pr.c:763:67: warning: incorrect type in argument 3 (different address spaces) drivers/target/target_core_pr.c:763:67: expected struct se_lun *lun drivers/target/target_core_pr.c:763:67: got struct se_lun [noderef] *se_lun drivers/target/target_core_pr.c:1718:68: warning: incorrect type in argument 3 (different address spaces) drivers/target/target_core_pr.c:1718:68: expected struct se_lun *lun drivers/target/target_core_pr.c:1718:68: got struct se_lun [noderef] *se_lun drivers/target/target_core_pr.c:3419:53: warning: incorrect type in argument 3 (different address spaces) drivers/target/target_core_pr.c:3419:53: expected struct se_lun *lun drivers/target/target_core_pr.c:3419:53: got struct se_lun [noderef] *se_lun drivers/target/target_core_pr.c:719:44: warning: dereference of noderef expression CC [M] drivers/target/target_core_pr.o CHECK drivers/target/target_core_alua.c drivers/target/target_core_alua.c:978:30: warning: incorrect type in assignment (different address spaces) drivers/target/target_core_alua.c:978:30: expected struct se_lun_acl *lacl drivers/target/target_core_alua.c:978:30: got struct se_lun_acl [noderef] *se_lun_acl drivers/target/target_core_alua.c:1938:36: warning: incorrect type in initializer (different address spaces) drivers/target/target_core_alua.c:1938:36: expected struct se_device *dev drivers/target/target_core_alua.c:1938:36: got struct se_device [noderef] *lun_se_dev drivers/target/target_core_alua.c:2192:36: warning: incorrect type in initializer (different address spaces) drivers/target/target_core_alua.c:2192:36: expected struct se_device *dev drivers/target/target_core_alua.c:2192:36: got struct se_device [noderef] *lun_se_dev CC [M] drivers/target/target_core_alua.o CHECK drivers/target/target_core_tmr.c CC [M] drivers/target/target_core_tmr.o CHECK drivers/target/target_core_tpg.c drivers/target/target_core_tpg.c:108:21: warning: incorrect type in assignment (different address spaces) drivers/target/target_core_tpg.c:108:21: expected struct se_device *dev drivers/target/target_core_tpg.c:108:21: got struct se_device [noderef] *lun_se_dev drivers/target/target_core_tpg.c:669:36: warning: incorrect type in initializer (different address spaces) drivers/target/target_core_tpg.c:669:36: expected struct se_device *dev drivers/target/target_core_tpg.c:669:36: got struct se_device [noderef] *lun_se_dev CC [M] drivers/target/target_core_tpg.o CHECK drivers/target/target_core_transport.c CC [M] drivers/target/target_core_transport.o CHECK drivers/target/target_core_sbc.c CC [M] drivers/target/target_core_sbc.o CHECK drivers/target/target_core_spc.c drivers/target/target_core_spc.c:695:17: error: incompatible types in comparison expression (different address spaces) CC [M] drivers/target/target_core_spc.o CHECK drivers/target/target_core_ua.c CC [M] drivers/target/target_core_ua.o CHECK drivers/target/target_core_rd.c CC [M] drivers/target/target_core_rd.o CHECK drivers/target/target_core_stat.c drivers/target/target_core_stat.c:549:13: warning: incorrect type in assignment (different address spaces) drivers/target/target_core_stat.c:549:13: expected struct se_device *dev drivers/target/target_core_stat.c:549:13: got struct se_device [noderef] *lun_se_dev drivers/target/target_core_stat.c:565:13: warning: incorrect type in assignment (different address spaces) drivers/target/target_core_stat.c:565:13: expected struct se_device *dev drivers/target/target_core_stat.c:565:13: got struct se_device [noderef] *lun_se_dev drivers/target/target_core_stat.c:595:13: warning: incorrect type in assignment (different address spaces) drivers/target/target_core_stat.c:595:13: expected struct se_device *dev drivers/target/target_core_stat.c:595:13: got struct se_device [noderef] *lun_se_dev drivers/target/target_core_stat.c:668:13: warning: incorrect type in assignment (different address spaces) drivers/target/target_core_stat.c:668:13: expected struct se_device *dev drivers/target/target_core_stat.c:668:13: got struct se_device [noderef] *lun_se_dev drivers/target/target_core_stat.c:684:13: warning: incorrect type in assignment (different address spaces) drivers/target/target_core_stat.c:684:13: expected struct se_device *dev drivers/target/target_core_stat.c:684:13: got struct se_device [noderef] *lun_se_dev drivers/target/target_core_stat.c:839:13: warning: incorrect type in assignment (different address spaces) drivers/target/target_core_stat.c:839:13: expected struct se_device *dev drivers/target/target_core_stat.c:839:13: got struct se_device [noderef] *lun_se_dev drivers/target/target_core_stat.c:879:13: warning: incorrect type in assignment (different address spaces) drivers/target/target_core_stat.c:879:13: expected struct se_device *dev drivers/target/target_core_stat.c:879:13: got struct se_device [noderef] *lun_se_dev drivers/target/target_core_stat.c:997:13: warning: incorrect type in assignment (different address spaces) drivers/target/target_core_stat.c:997:13: expected struct se_lun *lun drivers/target/target_core_stat.c:997:13: got struct se_lun [noderef] *se_lun drivers/target/target_core_stat.c:1363:13: warning: incorrect type in assignment (different address spaces) drivers/target/target_core_stat.c:1363:13: expected struct se_lun *lun drivers/target/target_core_stat.c:1363:13: got struct se_lun [noderef] *se_lun drivers/target/target_core_stat.c:999:52: warning: dereference of noderef expression drivers/target/target_core_stat.c:1365:52: warning: dereference of noderef expression CC [M] drivers/target/target_core_stat.o CHECK drivers/target/target_core_xcopy.c CC [M] drivers/target/target_core_xcopy.o LD [M] drivers/target/target_core_mod.o CHECK drivers/target/target_core_iblock.c CC [M] drivers/target/target_core_iblock.o CHECK drivers/target/target_core_file.c CC [M] drivers/target/target_core_file.o CHECK drivers/target/target_core_pscsi.c CC [M] drivers/target/target_core_pscsi.o CHECK drivers/target/iscsi/iscsi_target_parameters.c CC [M] drivers/target/iscsi/iscsi_target_parameters.o CHECK drivers/target/iscsi/iscsi_target_seq_pdu_list.c CC [M] drivers/target/iscsi/iscsi_target_seq_pdu_list.o CHECK drivers/target/iscsi/iscsi_target_auth.c CC [M] drivers/target/iscsi/iscsi_target_auth.o CHECK drivers/target/iscsi/iscsi_target_datain_values.c CC [M] drivers/target/iscsi/iscsi_target_datain_values.o CHECK drivers/target/iscsi/iscsi_target_device.c CC [M] drivers/target/iscsi/iscsi_target_device.o CHECK drivers/target/iscsi/iscsi_target_erl0.c CC [M] drivers/target/iscsi/iscsi_target_erl0.o CHECK drivers/target/iscsi/iscsi_target_erl1.c CC [M] drivers/target/iscsi/iscsi_target_erl1.o CHECK drivers/target/iscsi/iscsi_target_erl2.c CC [M] drivers/target/iscsi/iscsi_target_erl2.o CHECK drivers/target/iscsi/iscsi_target_login.c CC [M] drivers/target/iscsi/iscsi_target_login.o CHECK drivers/target/iscsi/iscsi_target_nego.c CC [M] drivers/target/iscsi/iscsi_target_nego.o CHECK drivers/target/iscsi/iscsi_target_nodeattrib.c CC [M] drivers/target/iscsi/iscsi_target_nodeattrib.o CHECK drivers/target/iscsi/iscsi_target_tmr.c CC [M] drivers/target/iscsi/iscsi_target_tmr.o CHECK drivers/target/iscsi/iscsi_target_tpg.c CC [M] drivers/target/iscsi/iscsi_target_tpg.o CHECK drivers/target/iscsi/iscsi_target_util.c CC [M] drivers/target/iscsi/iscsi_target_util.o CHECK drivers/target/iscsi/iscsi_target.c CC [M] drivers/target/iscsi/iscsi_target.o CHECK drivers/target/iscsi/iscsi_target_configfs.c CC [M] drivers/target/iscsi/iscsi_target_configfs.o CHECK drivers/target/iscsi/iscsi_target_stat.c CC [M] drivers/target/iscsi/iscsi_target_stat.o CHECK drivers/target/iscsi/iscsi_target_transport.c CC [M] drivers/target/iscsi/iscsi_target_transport.o LD [M] drivers/target/iscsi/iscsi_target_mod.o CHECK drivers/target/loopback/tcm_loop.c CC [M] drivers/target/loopback/tcm_loop.o CHECK drivers/target/sbp/sbp_target.c drivers/target/sbp/sbp_target.c:1909:21: warning: incorrect type in assignment (different address spaces) drivers/target/sbp/sbp_target.c:1909:21: expected struct se_device *dev drivers/target/sbp/sbp_target.c:1909:21: got struct se_device [noderef] *lun_se_dev -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/