Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161018AbbEVKuC (ORCPT ); Fri, 22 May 2015 06:50:02 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:41379 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751688AbbEVKt7 (ORCPT ); Fri, 22 May 2015 06:49:59 -0400 Date: Fri, 22 May 2015 13:49:46 +0300 From: Dan Carpenter To: Mike Shuey Cc: oleg.drokin@intel.com, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, HPDD-discuss@ml01.01.org, lustre-deve@lists.lustre.org Subject: Re: [PATCH v4 11/13] staging: lnet: o2iblnd: checkpatch.pl fixes Message-ID: <20150522104946.GK4150@mwanda> References: <1432237849-53947-1-git-send-email-shuey@purdue.edu> <1432237849-53947-12-git-send-email-shuey@purdue.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432237849-53947-12-git-send-email-shuey@purdue.edu> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 735 Lines: 19 On Thu, May 21, 2015 at 03:50:34PM -0400, Mike Shuey wrote: > @@ -2758,7 +2763,7 @@ void kiblnd_shutdown(lnet_ni_t *ni) > i = 2; > while (atomic_read(&net->ibn_npeers) != 0) { > i++; > - CDEBUG(((i & (-i)) == i) ? D_WARNING : D_NET, /* 2**n? */ > + CDEBUG(((i & (-i)) == i) ? D_WARNING : D_NET,/* 2**n? */ The original was better. I don't like this patch for the same reasons that people complained about patch 10. It does too many things as well. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/