Date: Fri, 22 May 2015 13:52:27 +0300
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: "Lu, Baolu" <baolu.lu@linux.intel.com>,
        David Cohen <david.a.cohen@linux.intel.com>,
        gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, balbi@ti.com
Subject: Re: [PATCH] usb: ulpi: don't register drivers if bus doesn't exist
Message-ID: <20150522105227.GA15649@kuha.fi.intel.com>
References: <1432150406-20550-1-git-send-email-sasha.levin@oracle.com>
 <20150520212235.GA20943@psi-dev26.jf.intel.com>
 <555D7DB4.6030606@linux.intel.com>
 <20150521072133.GA16847@kuha.fi.intel.com>
 <20150522101637.GB26704@kuha.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150522101637.GB26704@kuha.fi.intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1035
Lines: 31

On Fri, May 22, 2015 at 01:16:38PM +0300, Heikki Krogerus wrote:
> > > >>diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c
> > > >>index 0e6f968..0b0a5e7 100644
> > > >>--- a/drivers/usb/common/ulpi.c
> > > >>+++ b/drivers/usb/common/ulpi.c
> > > >>@@ -132,6 +132,10 @@ int ulpi_register_driver(struct ulpi_driver *drv)
> > > >>  	if (!drv->probe)
> > > >>  		return -EINVAL;
> > > >>+	/* Was the bus registered successfully? */
> > > >>+	if (!ulpi_bus.p)
> > > >>+		return -ENODEV;
> > 
> > I think we need to warn in this case. How about:
> > 
> >         if (unlikely(WARN_ON(!ulpi_bus.p)))
> >                 return -ENODEV;
> 
> I think we should also return -EAGAIN here.

The same check needs to be added to ulpi_register_interface() as well.


Cheers,

-- 
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/