Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756693AbbEVLFl (ORCPT ); Fri, 22 May 2015 07:05:41 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:38891 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751161AbbEVLFh (ORCPT ); Fri, 22 May 2015 07:05:37 -0400 Message-ID: <1432292734.3929.64.camel@pengutronix.de> Subject: Re: [PATCH v2] ARM: dts: nitrogen6x: add CAN support From: Philipp Zabel To: Peter Seiderer Cc: linux-kernel@vger.kernel.org, Mark Rutland , devicetree@vger.kernel.org, Russell King , Pawel Moll , Ian Campbell , Rob Herring , Sascha Hauer , Kumar Gala , Shawn Guo , linux-arm-kernel@lists.infradead.org Date: Fri, 22 May 2015 13:05:34 +0200 In-Reply-To: <1432230303-3414-1-git-send-email-ps.report@gmx.net> References: <1432230303-3414-1-git-send-email-ps.report@gmx.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1911 Lines: 54 Hi Peter, Am Donnerstag, den 21.05.2015, 19:45 +0200 schrieb Peter Seiderer: > Regulator stuff copied from imx6qdl-tx6.dtsi, pin configuration > taken from Boundary Devices linux kernel tree ([1] and [2]). > > [1] https://github.com/boundarydevices/linux-imx6/blob/boundary-imx_3.10.17_1.0.2_ga/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi > [2] https://github.com/boundarydevices/linux-imx6/blob/boundary-imx_3.10.17_1.0.2_ga/arch/arm/boot/dts/imx6qdl.dtsi > > Signed-off-by: Peter Seiderer > --- > v2: > - fix imx6qdl-nitrogen6x.dtsi url > - use real PAD settings (suggested by Fabio Estevam) > - remove _1 suffix (suggested by Shawn Guo) > --- > arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 32 +++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi > index fd096dc..d40092e 100644 > --- a/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi > @@ -54,6 +54,17 @@ > gpio = <&gpio3 22 0>; > enable-active-high; > }; > + > + reg_can_xcvr: regulator@3 { > + compatible = "regulator-fixed"; > + reg = <3>; > + regulator-name = "CAN XCVR"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_can_xcvr>; > + gpio = <&gpio1 2 GPIO_ACTIVE_HIGH>; According to Documentation/devicetree/bindings/regulator/fixed-regulator.txt this should have: enable-active-high; instead of the gpio phandle flag (which is ignored). Otherwise an active low GPIO is assumed. regards Philipp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/