Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756794AbbEVLYm (ORCPT ); Fri, 22 May 2015 07:24:42 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:33187 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756554AbbEVLXi (ORCPT ); Fri, 22 May 2015 07:23:38 -0400 Message-ID: <555F11B4.8000503@linaro.org> Date: Fri, 22 May 2015 19:23:32 +0800 From: Hanjun Guo User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Jiang Liu , "Rafael J . Wysocki" , Bjorn Helgaas , Marc Zyngier , Yijing Wang , Len Brown CC: Lv Zheng , LKML , linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, "x86 @ kernel . org" , linux-arm-kernel@lists.infradead.org, "Suthikulpanit, Suravee" Subject: Re: [Patch v3 5/7] PCI/ACPI: Consolidate common PCI host bridge code into ACPI core References: <1431593803-5213-1-git-send-email-jiang.liu@linux.intel.com> <1431593803-5213-6-git-send-email-jiang.liu@linux.intel.com> <5559E44B.2010702@linaro.org> <555BFC72.3060703@linux.intel.com> <555C0091.6050301@linaro.org> In-Reply-To: <555C0091.6050301@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1780 Lines: 45 On 2015年05月20日 11:33, Hanjun Guo wrote: > +CC Suravee, > > On 2015年05月20日 11:16, Jiang Liu wrote: >> On 2015/5/18 21:08, Hanjun Guo wrote: >>> Hi Jiang, >>> >>> On 2015年05月14日 16:56, Jiang Liu wrote: >>>> Introduce common interface acpi_pci_root_create() and related data >>>> structures to create PCI root bus for ACPI PCI host bridges. It will >>>> be used to kill duplicated arch specific code for IA64 and x86. It may >>>> also help ARM64 in future. >>> >>> As I commented in previous version, this patch will introduce >>> compile error on ACPI enabled ARM64 kernel because struct >>> pci_controller is not defined for ARM64, so how about adding >>> the following patch before this patch, or squash to this one, >>> does it make sense? >> Hi Hanjun, >> Thanks for fixing this building issue for ARM64. The patch >> is really what I want:). Will merge it into next version. With this >> patch applied, are there any other issues from ARM64 side? > > Suravee is testing ARM64 PCI on top of your patch set, he can confirm > that if there are any other issues :) (Suravee has a real ARM64 hardware > in hand) After confirmed with Suravee, this patch set works OK on ARM64 hardware for PCI hostbridge init, and can enumerate PCI devices (adding some ARM64 related PCI patches) and works fine with legacy interrupt, so to me, this patch set is good to go :) For this patchset: Tested-by: Suravee Suthikulpanit I will add my Reviewed-by for some of patches later. Thanks Hanjun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/