Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757238AbbEVL6A (ORCPT ); Fri, 22 May 2015 07:58:00 -0400 Received: from mail-pd0-f195.google.com ([209.85.192.195]:33998 "EHLO mail-pd0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756767AbbEVL55 (ORCPT ); Fri, 22 May 2015 07:57:57 -0400 Date: Fri, 22 May 2015 17:25:29 +0530 From: maitysanchayan@gmail.com To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, stefan@agner.ch, shawn.guo@linaro.org, kernel@pengutronix.de, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] soc: Add driver for Freescale Vybrid Platform Message-ID: <20150522115529.GA11118@Sanchayan-Arch.toradex.int> References: <35561091.AtkcGa6qVG@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <35561091.AtkcGa6qVG@wuerfel> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2403 Lines: 74 Hello Arnd, On 15-05-22 13:11:46, Arnd Bergmann wrote: > On Friday 22 May 2015 16:21:54 Sanchayan Maity wrote: > > +#define OCOTP_CFG0_OFFSET 0x00000410 > > +#define OCOTP_CFG1_OFFSET 0x00000420 > > +#define MSCM_CPxCOUNT_OFFSET 0x0000002C > > +#define MSCM_CPxCFG1_OFFSET 0x00000014 > > +#define ROM_REVISION_OFFSET 0x00000080 > > + > > +static const struct of_device_id vf610_soc_bus_match[] = { > > + { .compatible = "fsl,vf610-mscm-cpucfg", }, > > + { /* sentinel */ } > > +}; > > + > > +static int __init vf610_soc_init(void) > > +{ > > + struct regmap *ocotp_regmap, *mscm_regmap, *rom_regmap; > > + struct soc_device_attribute *soc_dev_attr; > > + struct soc_device *soc_dev; > > + struct device_node *np; > > + char soc_type[] = "xx0"; > > + u32 cpxcount, cpxcfg1; > > + u32 soc_id1, soc_id2, rom_rev; > > + u64 soc_id; > > + int ret; > > + > > + np = of_find_matching_node(NULL, vf610_soc_bus_match); > > + if (!np) > > + return -ENODEV; > > + > > Why not use module_platform_driver() and make this a probe function instead? Had done that but after having a look at the existing integrator and versatile platform implementation, I changed it. Will switch to using that. > > > + ocotp_regmap = syscon_regmap_lookup_by_compatible("fsl,vf610-ocotp"); > > + if (IS_ERR(ocotp_regmap)) { > > + pr_err("regmap lookup for octop failed\n"); > > + return PTR_ERR(ocotp_regmap); > > + } > > + > > + mscm_regmap = syscon_regmap_lookup_by_compatible("fsl,vf610-mscm-cpucfg"); > > + if (IS_ERR(mscm_regmap)) { > > + pr_err("regmap lookup for mscm failed"); > > + return PTR_ERR(mscm_regmap); > > + } > > + > > + rom_regmap = syscon_regmap_lookup_by_compatible("fsl,vf610-ocrom"); > > + if (IS_ERR(rom_regmap)) { > > + pr_err("regmap lookup for ocrom failed"); > > + return PTR_ERR(rom_regmap); > > + } > > Can you use syscon_regmap_lookup_by_phandle instead, and put the > phandles in the fsl,vf610-mscm-cpucfg node? Ok. Will do so. - Sanchayan. > > Also, I'd argue that the mscm should not be a syscon device at all, > but instead I'd use platform_get_resource()/devm_ioremap_resource() > to get an __iomem pointer. > > Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/