Date: Fri, 22 May 2015 21:44:11 +0900
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Marcin Jabrzyk <m.jabrzyk@samsung.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>, minchan@kernel.org,
        ngupta@vflare.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        kyungmin.park@samsung.com
Subject: Re: [PATCH] zram: check compressor name before setting it
Message-ID: <20150522124411.GA3793@swordfish>
References: <1432283515-2005-1-git-send-email-m.jabrzyk@samsung.com>
 <20150522085523.GA709@swordfish>
 <555EF30C.60108@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <555EF30C.60108@samsung.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1100
Lines: 32

On (05/22/15 11:12), Marcin Jabrzyk wrote:
> >
> >no.
> >
> >zram already complains about failed comp backend creation.
> >it's in dmesg (or syslog, etc.):
> >
> >	"zram: Cannot initialise %s compressing backend"
> >
> OK, now I see that. Sorry for the noise.
> 
> >second, there is not much value in exposing zcomp internals,
> >especially when the result is just another line in dmesg output.
> 
> From the other hand, the only valid values that can be written are
> in 'comp_algorithm'.
> So when writing other one, returning -EINVAL seems to be reasonable.
> The user would get immediately information that he can't do that,
> now the information can be very deferred in time.

it's not.
the error message appears in syslog right before we return -EINVAL
back to user.

	-ss

> I'm not for exposing more internals, but getting -EINVAL would be nice I
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/