Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757486AbbEVNZT (ORCPT ); Fri, 22 May 2015 09:25:19 -0400 Received: from casper.infradead.org ([85.118.1.10]:49276 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756867AbbEVNZR (ORCPT ); Fri, 22 May 2015 09:25:17 -0400 Date: Fri, 22 May 2015 15:25:14 +0200 From: Peter Zijlstra To: Stephane Eranian Cc: Ingo Molnar , Vince Weaver , Jiri Olsa , LKML Subject: Re: [PATCH 02/10] perf/x86: Improve HT workaround GP counter constraint Message-ID: <20150522132514.GC3644@twins.programming.kicks-ass.net> References: <20150521111710.475482798@infradead.org> <20150521111932.704264975@infradead.org> <20150522112146.GZ3644@twins.programming.kicks-ass.net> <20150522112800.GO18673@twins.programming.kicks-ass.net> <20150522125344.GA3644@twins.programming.kicks-ass.net> <20150522125908.GB3644@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 736 Lines: 16 On Fri, May 22, 2015 at 06:05:49AM -0700, Stephane Eranian wrote: > > I bet you tested the exclusive events earlier :-) Its one of the bugs, > > the n_excl accounting is leaking up. Once !0 it stays !0. > > So you're saying intel_put_excl_constraint() does not do the --n_excl? No it does, but we call get_events_constraints() every time we do x86_schedule_events(), and put_events_constraints() only on x86_pmu_del(). This means we call get() much more than we put(). Therefore leak up. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/