Date: Fri, 22 May 2015 08:25:28 -0500
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Minfei Huang <mhuang@redhat.com>
Cc: sjenning@redhat.com, jkosina@suse.cz, vojtech@suse.cz,
        live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
        Minfei Huang <mnfhuang@gmail.com>
Subject: Re: [PATCH] livepatch: Let compiler put module initialized function
 to  section ".init.text"
Message-ID: <20150522132528.GA20555@treble.redhat.com>
References: <1432275032-20678-1-git-send-email-mhuang@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1432275032-20678-1-git-send-email-mhuang@redhat.com>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1074
Lines: 33

On Fri, May 22, 2015 at 02:10:32PM +0800, Minfei Huang wrote:
> From: Minfei Huang <mnfhuang@gmail.com>
> 
> Usually we prefer to let compiler put the module initialized function to
> section ".init.text". Thus this text in memory will be freed in future.
> 
> Once we add the "__init" preceding function name, we can use following
> command to find it in specfied section.
> 
>   $ objdump -t -j .init.text built-in.o
> 
>   built-in.o:     file format elf64-x86-64
> 
>   SYMBOL TABLE:
>   0000000000000000 l    d  .init.text	0000000000000000 .init.text
>   0000000000000000 l     F .init.text	000000000000004e klp_init
> 
> Signed-off-by: Minfei Huang <mnfhuang@gmail.com>

The patch looks good but can you make the subject more concise?  Maybe
something like:

  livepatch: annotate klp_init() with __init

Thanks.

-- 
Josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/