Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932436AbbEVNzu (ORCPT ); Fri, 22 May 2015 09:55:50 -0400 Received: from mail-pd0-f182.google.com ([209.85.192.182]:33094 "EHLO mail-pd0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757191AbbEVNzs (ORCPT ); Fri, 22 May 2015 09:55:48 -0400 Message-ID: <555F355E.7060706@linaro.org> Date: Fri, 22 May 2015 21:55:42 +0800 From: Hanjun Guo User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Jiang Liu , "Rafael J . Wysocki" , Bjorn Helgaas , Marc Zyngier , Yijing Wang , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org CC: Lv Zheng , "lenb @ kernel . org" , LKML , linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [Patch v3 6/7] x86/PCI/ACPI: Use common interface to support PCI host bridge References: <1431593803-5213-1-git-send-email-jiang.liu@linux.intel.com> <1431593803-5213-7-git-send-email-jiang.liu@linux.intel.com> In-Reply-To: <1431593803-5213-7-git-send-email-jiang.liu@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1348 Lines: 42 On 2015年05月14日 16:56, Jiang Liu wrote: > Use common interface to simplify ACPI PCI host bridge implementation. > > Signed-off-by: Jiang Liu > --- > arch/x86/pci/acpi.c | 292 +++++++++++++++------------------------------------ > 1 file changed, 85 insertions(+), 207 deletions(-) > [...] > -static void release_pci_root_info(struct pci_host_bridge *bridge) > +static void pci_acpi_root_release_info(struct acpi_pci_root_info *ci) > { > - struct resource *res; > - struct resource_entry *entry; > - struct pci_root_info *info = bridge->release_data; > - > - resource_list_for_each_entry(entry, &bridge->windows) { > - res = entry->res; > - if (res->parent && > - (res->flags & (IORESOURCE_MEM | IORESOURCE_IO))) > - release_resource(res); > - } > - > - teardown_mcfg_map(info); > - kfree(info); > + teardown_mcfg_map(ci); > + kfree(ci); Implicit pointer cast? I think add a comment here that %p of ci is same as %p of info would be helpful for review and easy understood. other than that, Reviewed-by: Hanjun Guo Thanks Hanjun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/