Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757423AbbEVOsQ (ORCPT ); Fri, 22 May 2015 10:48:16 -0400 Received: from mga09.intel.com ([134.134.136.24]:1646 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757287AbbEVOsO (ORCPT ); Fri, 22 May 2015 10:48:14 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,475,1427785200"; d="scan'208";a="714279789" Date: Fri, 22 May 2015 14:48:13 +0000 (UTC) From: Keith Busch X-X-Sender: vmware@localhost.lm.intel.com To: Parav Pandit cc: Keith Busch , linux-nvme@lists.infradead.org, Matthew Wilcox , Jens Axboe , linux-kernel@vger.kernel.org Subject: Re: [PATCH] NVMe: Avoid interrupt disable during queue init. In-Reply-To: Message-ID: References: <1432253553-17045-1-git-send-email-parav.pandit@avagotech.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 868 Lines: 23 On Thu, 21 May 2015, Parav Pandit wrote: > On Fri, May 22, 2015 at 1:04 AM, Keith Busch wrote: >> The q_lock is held to protect polling from reading inconsistent data. > > ah, yes. I can see the nvme_kthread can poll the CQ while its getting > created through the nvme_resume(). > I think this opens up other issue. > > nvme_kthread() should, > > Instead of, > struct nvme_queue *nvmeq = dev->queues[i]; > > it should do, > struct nvme_queue *nvmeq = rcu_dereference(dev->queues[i]); The rcu protection on nvme queues was removed with the blk-mq conversion as we rely on that layer for h/w access. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/