Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757458AbbEVOvc (ORCPT ); Fri, 22 May 2015 10:51:32 -0400 Received: from mail-ig0-f175.google.com ([209.85.213.175]:37085 "EHLO mail-ig0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757161AbbEVOv2 (ORCPT ); Fri, 22 May 2015 10:51:28 -0400 MIME-Version: 1.0 In-Reply-To: References: <1432253553-17045-1-git-send-email-parav.pandit@avagotech.com> Date: Fri, 22 May 2015 20:21:27 +0530 Message-ID: Subject: Re: [PATCH] NVMe: Avoid interrupt disable during queue init. From: Parav Pandit To: Keith Busch Cc: linux-nvme@lists.infradead.org, Matthew Wilcox , Jens Axboe , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1150 Lines: 34 On Fri, May 22, 2015 at 8:18 PM, Keith Busch wrote: > On Thu, 21 May 2015, Parav Pandit wrote: >> >> On Fri, May 22, 2015 at 1:04 AM, Keith Busch >> wrote: >>> >>> The q_lock is held to protect polling from reading inconsistent data. >> >> >> ah, yes. I can see the nvme_kthread can poll the CQ while its getting >> created through the nvme_resume(). >> I think this opens up other issue. >> >> nvme_kthread() should, >> >> Instead of, >> struct nvme_queue *nvmeq = dev->queues[i]; >> >> it should do, >> struct nvme_queue *nvmeq = rcu_dereference(dev->queues[i]); > > > The rcu protection on nvme queues was removed with the blk-mq conversion > as we rely on that layer for h/w access. o.k. But above is at level where data I/Os are not even active. Its between nvme_kthread and nvme_resume() from power management subsystem. I must be missing something. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/