Date: Fri, 22 May 2015 09:36:08 -0600
From: Jonathan Corbet <corbet@lwn.net>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Joe Perches <joe@perches.com>, linux-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org
Subject: Re: [PATCH] Docs: SubmittingPatches: Clarify convention for git
 commit references
Message-ID: <20150522093608.420edaf7@lwn.net>
In-Reply-To: <20150521155954.9522.33952.stgit@bhelgaas-glaptop2.roam.corp.google.com>
References: <20150521155954.9522.33952.stgit@bhelgaas-glaptop2.roam.corp.google.com>
Organization: LWN.net
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 888
Lines: 23

On Thu, 21 May 2015 10:59:54 -0500
Bjorn Helgaas <bhelgaas@google.com> wrote:

> Clarify the convention for commit references in changelogs so it matches
> what checkpatch suggests; see d311cd44545f ("checkpatch: add test for
> commit id formatting style in commit log").
> 
> I chose a different example to make the ("") around the description more
> obvious.

In general the change is fine, and I agree with the change in example.
You took out the reasons for use of 12 characters, though, and I'd rather
not do that.  People like to know why a particular practice makes
sense...  Can I get a version that preserves that text?

Thanks,

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/