Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757569AbbEVPkC (ORCPT ); Fri, 22 May 2015 11:40:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58846 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756536AbbEVPkA (ORCPT ); Fri, 22 May 2015 11:40:00 -0400 Message-ID: <555F4DA8.5070100@redhat.com> Date: Fri, 22 May 2015 08:39:20 -0700 From: Alexander Duyck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Michal Kubecek , "David S. Miller" CC: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy Subject: Re: [PATCH net] ipv4: fill in table id when replacing a route References: <20150522114009.043A6A0CCC@unicorn.suse.cz> In-Reply-To: <20150522114009.043A6A0CCC@unicorn.suse.cz> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1204 Lines: 34 On 05/22/2015 04:40 AM, Michal Kubecek wrote: > When replacing an IPv4 route, tb_id member of the new fib_alias > structure is not set in the replace code path so that the new route is > ignored. > > Fixes: 0ddcf43d5d4a ("ipv4: FIB Local/MAIN table collapse") > > Signed-off-by: Michal Kubecek > --- > net/ipv4/fib_trie.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c > index 64c2076ced54..09b62e17dd8c 100644 > --- a/net/ipv4/fib_trie.c > +++ b/net/ipv4/fib_trie.c > @@ -1164,6 +1164,7 @@ int fib_table_insert(struct fib_table *tb, struct fib_config *cfg) > state = fa->fa_state; > new_fa->fa_state = state & ~FA_S_ACCESSED; > new_fa->fa_slen = fa->fa_slen; > + new_fa->tb_id = tb->tb_id; > > err = netdev_switch_fib_ipv4_add(key, plen, fi, > new_fa->fa_tos, > The patch looks good. Thanks. Acked-by: Alexander Duyck -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/