Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757714AbbEVQhU (ORCPT ); Fri, 22 May 2015 12:37:20 -0400 Received: from mail-wg0-f43.google.com ([74.125.82.43]:36139 "EHLO mail-wg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756894AbbEVQhS (ORCPT ); Fri, 22 May 2015 12:37:18 -0400 MIME-Version: 1.0 In-Reply-To: <1432307939-19640-1-git-send-email-cascardo@redhat.com> References: <1432307939-19640-1-git-send-email-cascardo@redhat.com> Date: Fri, 22 May 2015 09:37:17 -0700 Message-ID: Subject: Re: [PATCH] bridge: fix parsing of MLDv2 reports From: Cong Wang To: Thadeu Lima de Souza Cascardo Cc: Stephen Hemminger , David Miller , "bridge@lists.linux-foundation.org" , netdev , "linux-kernel@vger.kernel.org" , Hideaki YOSHIFUJI , Rik.Theys@esat.kuleuven.be Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1921 Lines: 48 On Fri, May 22, 2015 at 8:18 AM, Thadeu Lima de Souza Cascardo wrote: > When more than a multicast address is present in a MLDv2 report, all but > the first address is ignored, because the code breaks out of the loop if > there has not been an error adding that address. > > This has caused failures when two guests connected through the bridge > tried to communicate using IPv6. Neighbor discoveries would not be > transmitted to the other guest when both used a link-local address and a > static address. > > This only happens when there is a MLDv2 querier in the network. > > The fix will only break out of the loop when there is a failure adding a > multicast address. > > The mdb before the patch: > > dev ovirtmgmt port vnet0 grp ff02::1:ff7d:6603 temp > dev ovirtmgmt port vnet1 grp ff02::1:ff7d:6604 temp > dev ovirtmgmt port bond0.86 grp ff02::2 temp > > After the patch: > > dev ovirtmgmt port vnet0 grp ff02::1:ff7d:6603 temp > dev ovirtmgmt port vnet1 grp ff02::1:ff7d:6604 temp > dev ovirtmgmt port bond0.86 grp ff02::fb temp > dev ovirtmgmt port bond0.86 grp ff02::2 temp > dev ovirtmgmt port bond0.86 grp ff02::d temp > dev ovirtmgmt port vnet0 grp ff02::1:ff00:76 temp > dev ovirtmgmt port bond0.86 grp ff02::16 temp > dev ovirtmgmt port vnet1 grp ff02::1:ff00:77 temp > dev ovirtmgmt port bond0.86 grp ff02::1:ff00:def temp > dev ovirtmgmt port bond0.86 grp ff02::1:ffa1:40bf temp > > Reported-by: Rik Theys > Signed-off-by: Thadeu Lima de Souza Cascardo > Tested-by: Rik Theys Fixes: 08b202b67264 ("bridge br_multicast: IPv6 MLD support.") Good catch! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/