Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757884AbbEVQuU (ORCPT ); Fri, 22 May 2015 12:50:20 -0400 Received: from mail-qg0-f52.google.com ([209.85.192.52]:35639 "EHLO mail-qg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757568AbbEVQuR (ORCPT ); Fri, 22 May 2015 12:50:17 -0400 MIME-Version: 1.0 In-Reply-To: <1432244618-15548-1-git-send-email-ezequiel.garcia@imgtec.com> References: <1432244260-14908-1-git-send-email-ezequiel.garcia@imgtec.com> <1432244618-15548-1-git-send-email-ezequiel.garcia@imgtec.com> Date: Fri, 22 May 2015 09:50:16 -0700 X-Google-Sender-Auth: _LfDCZENfbqQiNG-ZcdzjolHRdU Message-ID: Subject: Re: [PATCH 7/7] mips: pistachio: Allow to enable the external timer based clocksource From: Andrew Bresticker To: Ezequiel Garcia Cc: "linux-kernel@vger.kernel.org" , Linux-MIPS , Daniel Lezcano , "devicetree@vger.kernel.org" , James Hartley , James Hogan , Thomas Gleixner , Damien Horsley , Govindraj Raja Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1732 Lines: 44 On Thu, May 21, 2015 at 2:43 PM, Ezequiel Garcia wrote: > This commit introduces a new config, so the user can choose to enable > the General Purpose Timer based clocksource. This option is required > to have CPUFreq support. > > Signed-off-by: Ezequiel Garcia > --- > arch/mips/Kconfig | 1 + > arch/mips/pistachio/Kconfig | 13 +++++++++++++ > 2 files changed, 14 insertions(+) > create mode 100644 arch/mips/pistachio/Kconfig > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig > index f501665..91f6ca0 100644 > --- a/arch/mips/Kconfig > +++ b/arch/mips/Kconfig > @@ -934,6 +934,7 @@ source "arch/mips/jazz/Kconfig" > source "arch/mips/jz4740/Kconfig" > source "arch/mips/lantiq/Kconfig" > source "arch/mips/lasat/Kconfig" > +source "arch/mips/pistachio/Kconfig" > source "arch/mips/pmcs-msp71xx/Kconfig" > source "arch/mips/ralink/Kconfig" > source "arch/mips/sgi-ip27/Kconfig" > diff --git a/arch/mips/pistachio/Kconfig b/arch/mips/pistachio/Kconfig > new file mode 100644 > index 0000000..97731ea > --- /dev/null > +++ b/arch/mips/pistachio/Kconfig > @@ -0,0 +1,13 @@ > +config PISTACHIO_GPTIMER_CLKSRC > + bool "Enable General Purpose Timer based clocksource" > + depends on MACH_PISTACHIO > + select CLKSRC_PISTACHIO > + select MIPS_EXTERNAL_TIMER Why not just select these in the MACH_PISTACHIO Kconfig entry? Is there any harm in always having the Pistachio GPT enabled? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/