Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757863AbbEVQ7e (ORCPT ); Fri, 22 May 2015 12:59:34 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:23585 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757077AbbEVQ7b (ORCPT ); Fri, 22 May 2015 12:59:31 -0400 From: James Hartley To: Andrew Bresticker , Ezequiel Garcia CC: "linux-kernel@vger.kernel.org" , Linux-MIPS , Daniel Lezcano , "devicetree@vger.kernel.org" , James Hogan , Thomas Gleixner , "Damien Horsley" , Govindraj Raja Subject: RE: [PATCH 7/7] mips: pistachio: Allow to enable the external timer based clocksource Thread-Topic: [PATCH 7/7] mips: pistachio: Allow to enable the external timer based clocksource Thread-Index: AQHQlA+qn4NTNngiBUaByn6HDeB+iJ2IJd4AgAASJKA= Date: Fri, 22 May 2015 16:58:28 +0000 Message-ID: <72BC0C8BD7BB6F45988A99382E5FBAE5445286D0@hhmail02.hh.imgtec.org> References: <1432244260-14908-1-git-send-email-ezequiel.garcia@imgtec.com> <1432244618-15548-1-git-send-email-ezequiel.garcia@imgtec.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [192.168.167.65] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t4MGxdX8029157 Content-Length: 2354 Lines: 56 > -----Original Message----- > From: abrestic@google.com [mailto:abrestic@google.com] On Behalf Of > Andrew Bresticker > Sent: 22 May 2015 17:50 > To: Ezequiel Garcia > Cc: linux-kernel@vger.kernel.org; Linux-MIPS; Daniel Lezcano; > devicetree@vger.kernel.org; James Hartley; James Hogan; Thomas Gleixner; > Damien Horsley; Govindraj Raja > Subject: Re: [PATCH 7/7] mips: pistachio: Allow to enable the external timer > based clocksource > > On Thu, May 21, 2015 at 2:43 PM, Ezequiel Garcia > wrote: > > This commit introduces a new config, so the user can choose to enable > > the General Purpose Timer based clocksource. This option is required > > to have CPUFreq support. > > > > Signed-off-by: Ezequiel Garcia > > --- > > arch/mips/Kconfig | 1 + > > arch/mips/pistachio/Kconfig | 13 +++++++++++++ > > 2 files changed, 14 insertions(+) > > create mode 100644 arch/mips/pistachio/Kconfig > > > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig index > > f501665..91f6ca0 100644 > > --- a/arch/mips/Kconfig > > +++ b/arch/mips/Kconfig > > @@ -934,6 +934,7 @@ source "arch/mips/jazz/Kconfig" > > source "arch/mips/jz4740/Kconfig" > > source "arch/mips/lantiq/Kconfig" > > source "arch/mips/lasat/Kconfig" > > +source "arch/mips/pistachio/Kconfig" > > source "arch/mips/pmcs-msp71xx/Kconfig" > > source "arch/mips/ralink/Kconfig" > > source "arch/mips/sgi-ip27/Kconfig" > > diff --git a/arch/mips/pistachio/Kconfig b/arch/mips/pistachio/Kconfig > > new file mode 100644 index 0000000..97731ea > > --- /dev/null > > +++ b/arch/mips/pistachio/Kconfig > > @@ -0,0 +1,13 @@ > > +config PISTACHIO_GPTIMER_CLKSRC > > + bool "Enable General Purpose Timer based clocksource" > > + depends on MACH_PISTACHIO > > + select CLKSRC_PISTACHIO > > + select MIPS_EXTERNAL_TIMER > > Why not just select these in the MACH_PISTACHIO Kconfig entry? Is there any > harm in always having the Pistachio GPT enabled? It does mean that there are less GPT's available for other users, and whilst I'm not aware of any use cases that currently require all 4, perhaps having the flexibility is worth it. James ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?