Date: Fri, 22 May 2015 19:22:45 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Alexei Starovoitov <ast@plumgrid.com>
Cc: Wang Nan <wangnan0@huawei.com>, paulus@samba.org, a.p.zijlstra@chello.nl,
        mingo@redhat.com, acme@kernel.org, namhyung@kernel.org,
        jolsa@kernel.org, dsahern@gmail.com, daniel@iogearbox.net,
        brendan.d.gregg@gmail.com, masami.hiramatsu.pt@hitachi.com,
        lizefan@huawei.com, linux-kernel@vger.kernel.org, pi3orama@163.com
Subject: Re: [RFC PATCH v3 08/37] bpf tools: Define basic interface
Message-ID: <20150522172244.GC6609@krava.redhat.com>
References: <1431860222-61636-1-git-send-email-wangnan0@huawei.com>
 <1431860222-61636-9-git-send-email-wangnan0@huawei.com>
 <555A2810.3080501@plumgrid.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <555A2810.3080501@plumgrid.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1201
Lines: 43

On Mon, May 18, 2015 at 10:57:36AM -0700, Alexei Starovoitov wrote:
> On 5/17/15 3:56 AM, Wang Nan wrote:
> >bpf_open_object() and bpf_close_object() are open and close function of
> >eBPF object files. 'struct bpf_object' will be handler of one object
> >file. Its internal structure is hide to user.
> >
> >Signed-off-by: Wang Nan <wangnan0@huawei.com>
> >---
> ...
> >+
> >+struct bpf_object *bpf_open_object(const char *path)
> >+{
> >+	return NULL;
> >+}
> >+
> >+void bpf_close_object(struct bpf_object *object)
> >+{
> >+	return 0;
> >+}
> 
> I'm not a fan of introducing empty helpers. I would
> squash it with the patch that actually adds meat to it.
> 

agreed, also:

[jolsa@krava bpf]$ make
  CC       libbpf.o
libbpf.c: In function ‘bpf_close_object’:
libbpf.c:68:2: warning: ‘return’ with a value, in function returning void [enabled by default]
  return 0;
  ^
  LD       libbpf-in.o
  LINK     libbpf.a
  LINK     libbpf.so


jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/