Date: Fri, 22 May 2015 19:24:01 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Wang Nan <wangnan0@huawei.com>
Cc: paulus@samba.org, a.p.zijlstra@chello.nl, mingo@redhat.com,
        acme@kernel.org, namhyung@kernel.org, jolsa@kernel.org,
        dsahern@gmail.com, ast@plumgrid.com, daniel@iogearbox.net,
        brendan.d.gregg@gmail.com, masami.hiramatsu.pt@hitachi.com,
        lizefan@huawei.com, linux-kernel@vger.kernel.org, pi3orama@163.com
Subject: Re: [RFC PATCH v3 20/37] bpf tools: Add bpf.c/h for common bpf
 operations
Message-ID: <20150522172401.GF6609@krava.redhat.com>
References: <1431860222-61636-1-git-send-email-wangnan0@huawei.com>
 <1431860222-61636-21-git-send-email-wangnan0@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1431860222-61636-21-git-send-email-wangnan0@huawei.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 861
Lines: 30

On Sun, May 17, 2015 at 10:56:45AM +0000, Wang Nan wrote:

SNIP

> diff --git a/tools/lib/bpf/bpf.h b/tools/lib/bpf/bpf.h
> new file mode 100644
> index 0000000..1e9a53b
> --- /dev/null
> +++ b/tools/lib/bpf/bpf.h
> @@ -0,0 +1,17 @@
> +/*
> + * common eBPF ELF operations.
> + *
> + * Copyright (C) 2015, Wang Nan <wangnan0@huawei.com>
> + * Copyright (C) 2015, Huawei Inc.
> + *
> + * Released under the GPL v2. (and only v2, not any later version)
> + */
> +#ifndef __LIBBPF_BPF_H
> +#define __LIBBPF_BPF_H

libbpf.h uses __BPF_LIBBPF_H ... you might want to come
with some common pattern for these defines

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/