Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946414AbbEVRZD (ORCPT ); Fri, 22 May 2015 13:25:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34454 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946348AbbEVRZA (ORCPT ); Fri, 22 May 2015 13:25:00 -0400 Date: Fri, 22 May 2015 19:24:49 +0200 From: Jiri Olsa To: Wang Nan Cc: paulus@samba.org, a.p.zijlstra@chello.nl, mingo@redhat.com, acme@kernel.org, namhyung@kernel.org, jolsa@kernel.org, dsahern@gmail.com, ast@plumgrid.com, daniel@iogearbox.net, brendan.d.gregg@gmail.com, masami.hiramatsu.pt@hitachi.com, lizefan@huawei.com, linux-kernel@vger.kernel.org, pi3orama@163.com Subject: Re: [RFC PATCH v3 32/37] perf bpf: Parse probe points of eBPF programs during preparation Message-ID: <20150522172449.GI6609@krava.redhat.com> References: <1431860222-61636-1-git-send-email-wangnan0@huawei.com> <1431860222-61636-33-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431860222-61636-33-git-send-email-wangnan0@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 720 Lines: 27 On Sun, May 17, 2015 at 10:56:57AM +0000, Wang Nan wrote: SNIP > + if (pev) > + clear_perf_probe_event(pev); > + return err; > +} > + > int bpf_prepare_load(const char *filename) > { > struct bpf_object *obj; > @@ -81,6 +150,8 @@ int bpf_prepare_load(const char *filename) > return -EINVAL; > } > pr_debug("bpf: add program '%s'\n", title); > + > + bpf_do_config(params.nr_progs - 1, title); shouldn't you check&pass return value of bpf_do_config ? jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/